Remove the space before the slash in network XML

This matches the style we use elsewhere and allows nat-network-dns-srv-record{,-minimal}.xml to be tested in network XML -> XML test.

Remove the space before the slash in network XML
This matches the style we use elsewhere and allows nat-network-dns-srv-record{,-minimal}.xml to be tested in network XML -> XML test.
d8bd24a9 · Ján Tomko · 63ee776f · d8bd24a9 · d8bd24a9 · d8bd24a9
42 changed file
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -2283,7 +2283,7 @@ virNetworkDNSDefFormat(virBufferPtr buf,
    virBufferAdjustIndent(buf, 2);

    for (i = 0; i < def->ntxts; i++) {
-        virBufferAsprintf(buf, "<txt name='%s' value='%s' />\n",
+        virBufferAsprintf(buf, "<txt name='%s' value='%s'/>\n",
                              def->txts[i].name,
                              def->txts[i].value);
    }
@@ -2362,7 +2362,7 @@ virNetworkIpDefFormat(virBufferPtr buf,
    virBufferAdjustIndent(buf, 2);

    if (def->tftproot) {
-        virBufferEscapeString(buf, "<tftp root='%s' />\n",
+        virBufferEscapeString(buf, "<tftp root='%s'/>\n",
                              def->tftproot);
    }
    if ((def->nranges || def->nhosts)) {
@@ -2379,36 +2379,36 @@ virNetworkIpDefFormat(virBufferPtr buf,
                VIR_FREE(saddr);
                goto error;
            }
-            virBufferAsprintf(buf, "<range start='%s' end='%s' />\n",
+            virBufferAsprintf(buf, "<range start='%s' end='%s'/>\n",
                              saddr, eaddr);
            VIR_FREE(saddr);
            VIR_FREE(eaddr);
        }
        for (i = 0; i < def->nhosts; i++) {
-            virBufferAddLit(buf, "<host ");
+            virBufferAddLit(buf, "<host");
            if (def->hosts[i].mac)
-                virBufferAsprintf(buf, "mac='%s' ", def->hosts[i].mac);
+                virBufferAsprintf(buf, " mac='%s'", def->hosts[i].mac);
            if (def->hosts[i].id)
-                virBufferAsprintf(buf, "id='%s' ", def->hosts[i].id);
+                virBufferAsprintf(buf, " id='%s'", def->hosts[i].id);
            if (def->hosts[i].name)
-                virBufferAsprintf(buf, "name='%s' ", def->hosts[i].name);
+                virBufferAsprintf(buf, " name='%s'", def->hosts[i].name);
            if (VIR_SOCKET_ADDR_VALID(&def->hosts[i].ip)) {
                char *ipaddr = virSocketAddrFormat(&def->hosts[i].ip);
                if (!ipaddr)
                    goto error;
-                virBufferAsprintf(buf, "ip='%s' ", ipaddr);
+                virBufferAsprintf(buf, " ip='%s'", ipaddr);
                VIR_FREE(ipaddr);
            }
            virBufferAddLit(buf, "/>\n");
        }
        if (def->bootfile) {
-            virBufferEscapeString(buf, "<bootp file='%s' ",
+            virBufferEscapeString(buf, "<bootp file='%s'",
                                  def->bootfile);
            if (VIR_SOCKET_ADDR_VALID(&def->bootserver)) {
                char *ipaddr = virSocketAddrFormat(&def->bootserver);
                if (!ipaddr)
                    goto error;
-                virBufferEscapeString(buf, "server='%s' ", ipaddr);
+                virBufferEscapeString(buf, " server='%s'", ipaddr);
                VIR_FREE(ipaddr);
            }
            virBufferAddLit(buf, "/>\n");
@@ -2656,12 +2656,12 @@ virNetworkDefFormatInternal(virBufferPtr buf,
        virBufferAddLit(buf, "<bridge");
        if (def->bridge)
            virBufferEscapeString(buf, " name='%s'", def->bridge);
-        virBufferAsprintf(buf, " stp='%s' delay='%ld' />\n",
+        virBufferAsprintf(buf, " stp='%s' delay='%ld'/>\n",
                          def->stp ? "on" : "off",
                          def->delay);
    } else if (def->forward.type == VIR_NETWORK_FORWARD_BRIDGE &&
               def->bridge) {
-        virBufferEscapeString(buf, "<bridge name='%s' />\n", def->bridge);
+        virBufferEscapeString(buf, "<bridge name='%s'/>\n", def->bridge);
    }



--- a/src/network/default.xml
+++ b/src/network/default.xml
 <network>
  <name>default</name>
-  <bridge name="virbr0" />
+  <bridge name="virbr0"/>
  <forward/>
  <ip address="192.168.122.1" netmask="255.255.255.0">
    <dhcp>
-      <range start="192.168.122.2" end="192.168.122.254" />
+      <range start="192.168.122.2" end="192.168.122.254"/>
    </dhcp>
  </ip>
 </network>
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -250,11 +250,11 @@ static const char *defaultNetworkXML =
 "<network>"
 "  <name>default</name>"
 "  <uuid>dd8fe884-6c02-601e-7551-cca97df1c5df</uuid>"
-"  <bridge name='virbr0' />"
+"  <bridge name='virbr0'/>"
 "  <forward/>"
 "  <ip address='192.168.122.1' netmask='255.255.255.0'>"
 "    <dhcp>"
-"      <range start='192.168.122.2' end='192.168.122.254' />"
+"      <range start='192.168.122.2' end='192.168.122.254'/>"
 "    </dhcp>"
 "  </ip>"
 "</network>";

--- a/tests/networkxml2confdata/dhcp6-nat-network.xml
+++ b/tests/networkxml2confdata/dhcp6-nat-network.xml
@@ -2,24 +2,24 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>
  </ip>
  <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'>
    <dhcp>
-      <range start='2001:db8:ac10:fd01::1:10' end='2001:db8:ac10:fd01::1:ff' />
-      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20' />
-      <host name='paul' ip='2001:db8:ac10:fd01::1:21' />
-      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22' />
-      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23' />
-      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24' />
+      <range start='2001:db8:ac10:fd01::1:10' end='2001:db8:ac10:fd01::1:ff'/>
+      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20'/>
+      <host name='paul' ip='2001:db8:ac10:fd01::1:21'/>
+      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22'/>
+      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23'/>
+      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='10.24.10.1'>

--- a/tests/networkxml2confdata/dhcp6-network.xml
+++ b/tests/networkxml2confdata/dhcp6-network.xml
@@ -2,16 +2,16 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <domain name='mynet'/>
  <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'>
    <dhcp>
-      <range start='2001:db8:ac10:fd01::1:10' end='2001:db8:ac10:fd01::1:ff' />
-      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20' />
-      <host name='paul' ip='2001:db8:ac10:fd01::1:21' />
-      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22' />
-      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23' />
-      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24' />
+      <range start='2001:db8:ac10:fd01::1:10' end='2001:db8:ac10:fd01::1:ff'/>
+      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20'/>
+      <host name='paul' ip='2001:db8:ac10:fd01::1:21'/>
+      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22'/>
+      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23'/>
+      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2confdata/dhcp6host-routed-network.xml
+++ b/tests/networkxml2confdata/dhcp6host-routed-network.xml
@@ -2,21 +2,21 @@
  <name>local</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='route'/>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='12:34:56:78:9A:BC'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'>
    <dhcp>
-      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20' />
-      <host name='paul' ip='2001:db8:ac10:fd01::1:21' />
-      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22' />
-      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23' />
-      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24' />
+      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20'/>
+      <host name='paul' ip='2001:db8:ac10:fd01::1:21'/>
+      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22'/>
+      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23'/>
+      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2confdata/isolated-network.xml
+++ b/tests/networkxml2confdata/isolated-network.xml
 <network>
  <name>private</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name='virbr2' stp='on' delay='0' />
+  <bridge name='virbr2' stp='on' delay='0'/>
  <mac address='52:54:00:17:3F:37'/>
  <ip address='192.168.152.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.152.2' end='192.168.152.254' />
+      <range start='192.168.152.2' end='192.168.152.254'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2confdata/nat-network-dns-hosts.xml
+++ b/tests/networkxml2confdata/nat-network-dns-hosts.xml
@@ -2,7 +2,7 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid>
  <forward dev='eth0' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <domain name="example.com"/>
  <dns forwardPlainNames='no'>
    <host ip='192.168.122.1'>

--- a/tests/networkxml2confdata/nat-network-dns-srv-record-minimal.xml
+++ b/tests/networkxml2confdata/nat-network-dns-srv-record-minimal.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' />
+    <srv service='name' protocol='tcp'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2confdata/nat-network-dns-srv-record.xml
+++ b/tests/networkxml2confdata/nat-network-dns-srv-record.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10' />
+    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2confdata/nat-network-dns-txt-record.xml
+++ b/tests/networkxml2confdata/nat-network-dns-txt-record.xml
@@ -2,15 +2,15 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <txt name='example' value='example value' />
+    <txt name='example' value='example value'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2confdata/nat-network.xml
+++ b/tests/networkxml2confdata/nat-network.xml
@@ -2,12 +2,12 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2confdata/netboot-network.xml
+++ b/tests/networkxml2confdata/netboot-network.xml
@@ -2,13 +2,13 @@
  <name>netboot</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='off' delay='1' />
+  <bridge name='virbr1' stp='off' delay='1'/>
  <domain name='example.com'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
-    <tftp root='/var/lib/tftproot' />
+    <tftp root='/var/lib/tftproot'/>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <bootp file='pxeboot.img' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <bootp file='pxeboot.img'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2confdata/netboot-proxy-network.xml
+++ b/tests/networkxml2confdata/netboot-proxy-network.xml
@@ -2,12 +2,12 @@
  <name>netboot</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='off' delay='1' />
+  <bridge name='virbr1' stp='off' delay='1'/>
  <domain name='example.com'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <bootp file='pxeboot.img' server='10.20.30.40' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <bootp file='pxeboot.img' server='10.20.30.40'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2confdata/routed-network.xml
+++ b/tests/networkxml2confdata/routed-network.xml
@@ -2,7 +2,7 @@
  <name>local</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='route'/>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='12:34:56:78:9A:BC'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
  </ip>

--- a/tests/networkxml2xmlin/bandwidth-network.xml
+++ b/tests/networkxml2xmlin/bandwidth-network.xml
@@ -2,7 +2,7 @@
  <name>test-net</name>
  <uuid>986fed9e-a488-186d-ef2d-17ebfd1993f8</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='52:54:00:E6:A2:C9'/>
  <bandwidth>
    <inbound average='1000' peak='2000' burst='1024'/>
@@ -10,7 +10,7 @@
  </bandwidth>
  <ip address='192.168.120.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.120.2' end='192.168.120.254' />
+      <range start='192.168.120.2' end='192.168.120.254'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlin/dhcp6host-routed-network.xml
+++ b/tests/networkxml2xmlin/dhcp6host-routed-network.xml
@@ -2,21 +2,21 @@
  <name>local</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='route'/>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='12:34:56:78:9A:BC'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'>
    <dhcp>
-      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20' />
-      <host name='paul' ip='2001:db8:ac10:fd01::1:21' />
-      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22' />
-      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23' />
-      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24' />
+      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20'/>
+      <host name='paul' ip='2001:db8:ac10:fd01::1:21'/>
+      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22'/>
+      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23'/>
+      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/>
    </dhcp>
  </ip>
  <route address="192.168.222.0" netmask="255.255.255.0" gateway="192.168.122.10"/>

--- a/tests/networkxml2xmlin/empty-allow-ipv6.xml
+++ b/tests/networkxml2xmlin/empty-allow-ipv6.xml
 <network ipv6='yes'>
  <name>empty</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid>
-  <bridge name='virbr7' />
+  <bridge name='virbr7'/>
  <mac address='52:54:00:17:3F:47'/>
 </network>
--- a/tests/networkxml2xmlin/isolated-network.xml
+++ b/tests/networkxml2xmlin/isolated-network.xml
 <network ipv6='no'>
  <name>private</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name="virbr2" />
+  <bridge name="virbr2"/>
  <mac address='52:54:00:17:3F:37'/>
  <ip address="192.168.152.1" netmask="255.255.255.0">
    <dhcp>
-      <range start="192.168.152.2" end="192.168.152.254" />
+      <range start="192.168.152.2" end="192.168.152.254"/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlin/nat-network-dns-hosts.xml
+++ b/tests/networkxml2xmlin/nat-network-dns-hosts.xml
@@ -2,7 +2,7 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid>
  <forward dev='eth0' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns forwardPlainNames='no'>
    <host ip='192.168.122.1'>
      <hostname>host</hostname>

--- a/tests/networkxml2xmlin/nat-network-dns-srv-record-minimal.xml
+++ b/tests/networkxml2xmlin/nat-network-dns-srv-record-minimal.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' />
+    <srv service='name' protocol='tcp'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlin/nat-network-dns-srv-record.xml
+++ b/tests/networkxml2xmlin/nat-network-dns-srv-record.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10' />
+    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlin/nat-network-dns-txt-record.xml
+++ b/tests/networkxml2xmlin/nat-network-dns-txt-record.xml
@@ -2,15 +2,15 @@
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward dev='eth1' mode='nat'/>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <txt name='example' value='example value' />
+    <txt name='example' value='example value'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlin/nat-network.xml
+++ b/tests/networkxml2xmlin/nat-network.xml
 <network>
  <name>default</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name="virbr0" />
+  <bridge name="virbr0"/>
  <forward mode="nat" dev="eth1"/>
  <ip address="192.168.122.1" netmask="255.255.255.0">
    <dhcp>
-      <range start="192.168.122.2" end="192.168.122.254" />
-      <host mac="00:16:3e:77:e2:ed" name="a.example.com" ip="192.168.122.10" />
-      <host mac="00:16:3e:3e:a9:1a" name="b.example.com" ip="192.168.122.11" />
+      <range start="192.168.122.2" end="192.168.122.254"/>
+      <host mac="00:16:3e:77:e2:ed" name="a.example.com" ip="192.168.122.10"/>
+      <host mac="00:16:3e:3e:a9:1a" name="b.example.com" ip="192.168.122.11"/>
    </dhcp>
  </ip>
  <ip family="ipv4" address="192.168.123.1" netmask="255.255.255.0">

--- a/tests/networkxml2xmlin/netboot-network.xml
+++ b/tests/networkxml2xmlin/netboot-network.xml
@@ -5,10 +5,10 @@
  <domain name="example.com"/>
  <forward/>
  <ip address="192.168.122.1" netmask="255.255.255.0">
-    <tftp root="/var/lib/tftproot" />
+    <tftp root="/var/lib/tftproot"/>
    <dhcp>
-      <range start="192.168.122.2" end="192.168.122.254" />
-      <bootp file="pxeboot.img" />
+      <range start="192.168.122.2" end="192.168.122.254"/>
+      <bootp file="pxeboot.img"/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlin/netboot-proxy-network.xml
+++ b/tests/networkxml2xmlin/netboot-proxy-network.xml
@@ -6,8 +6,8 @@
  <forward/>
  <ip address="192.168.122.1" netmask="255.255.255.0">
    <dhcp>
-      <range start="192.168.122.2" end="192.168.122.254" />
-      <bootp file="pxeboot.img" server="10.20.30.40" />
+      <range start="192.168.122.2" end="192.168.122.254"/>
+      <bootp file="pxeboot.img" server="10.20.30.40"/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlin/routed-network.xml
+++ b/tests/networkxml2xmlin/routed-network.xml
 <network>
  <name>local</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name="virbr1" />
+  <bridge name="virbr1"/>
  <mac address='12:34:56:78:9A:BC'/>
  <forward mode="route" dev="eth1"/>
  <ip address="192.168.122.1" netmask="255.255.255.0">

--- a/tests/networkxml2xmlout/bandwidth-network.xml
+++ b/tests/networkxml2xmlout/bandwidth-network.xml
@@ -2,7 +2,7 @@
  <name>test-net</name>
  <uuid>986fed9e-a488-186d-ef2d-17ebfd1993f8</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='52:54:00:e6:a2:c9'/>
  <bandwidth>
    <inbound average='1000' peak='2000' burst='1024'/>
@@ -10,7 +10,7 @@
  </bandwidth>
  <ip address='192.168.120.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.120.2' end='192.168.120.254' />
+      <range start='192.168.120.2' end='192.168.120.254'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlout/dhcp6host-routed-network.xml
+++ b/tests/networkxml2xmlout/dhcp6host-routed-network.xml
@@ -4,21 +4,21 @@
  <forward dev='eth1' mode='route'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='12:34:56:78:9a:bc'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv6' address='2001:db8:ac10:fd01::1' prefix='64'>
    <dhcp>
-      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20' />
-      <host name='paul' ip='2001:db8:ac10:fd01::1:21' />
-      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22' />
-      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23' />
-      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24' />
+      <host id='0:4:7e:7d:f0:7d:a8:bc:c5:d2:13:32:11:ed:16:ea:84:63' ip='2001:db8:ac10:fd01::1:20'/>
+      <host name='paul' ip='2001:db8:ac10:fd01::1:21'/>
+      <host id='0:3:0:1:0:16:3e:11:22:33' name='peter.xyz' ip='2001:db8:ac10:fd01::1:22'/>
+      <host id='0:3:0:1:0:16:3e:44:55:33' ip='2001:db8:ac10:fd01::1:23'/>
+      <host id='0:1:0:1:18:aa:62:fe:0:16:3e:44:55:66' name='badbob' ip='2001:db8:ac10:fd01::1:24'/>
    </dhcp>
  </ip>
  <route address='192.168.222.0' netmask='255.255.255.0' gateway='192.168.122.10'/>

--- a/tests/networkxml2xmlout/empty-allow-ipv6.xml
+++ b/tests/networkxml2xmlout/empty-allow-ipv6.xml
 <network ipv6='yes'>
  <name>empty</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9c</uuid>
-  <bridge name='virbr7' stp='on' delay='0' />
+  <bridge name='virbr7' stp='on' delay='0'/>
  <mac address='52:54:00:17:3f:47'/>
 </network>
--- a/tests/networkxml2xmlout/host-bridge-net.xml
+++ b/tests/networkxml2xmlout/host-bridge-net.xml
@@ -2,5 +2,5 @@
  <name>host-bridge-net</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a8e</uuid>
  <forward mode='bridge'/>
-  <bridge name='br0' />
+  <bridge name='br0'/>
 </network>
--- a/tests/networkxml2xmlout/isolated-network.xml
+++ b/tests/networkxml2xmlout/isolated-network.xml
 <network>
  <name>private</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name='virbr2' stp='on' delay='0' />
+  <bridge name='virbr2' stp='on' delay='0'/>
  <mac address='52:54:00:17:3f:37'/>
  <ip address='192.168.152.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.152.2' end='192.168.152.254' />
+      <range start='192.168.152.2' end='192.168.152.254'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlout/nat-network-dns-forward-plain.xml
+++ b/tests/networkxml2xmlout/nat-network-dns-forward-plain.xml
@@ -4,7 +4,7 @@
  <forward dev='eth0' mode='nat'>
    <interface dev='eth0'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns forwardPlainNames='yes'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
  </ip>

--- a/tests/networkxml2xmlout/nat-network-dns-hosts.xml
+++ b/tests/networkxml2xmlout/nat-network-dns-hosts.xml
@@ -4,7 +4,7 @@
  <forward dev='eth0' mode='nat'>
    <interface dev='eth0'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
    <host ip='192.168.122.1'>
      <hostname>host</hostname>

--- a/tests/networkxml2xmlout/nat-network-dns-srv-record-minimal.xml
+++ b/tests/networkxml2xmlout/nat-network-dns-srv-record-minimal.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' />
+    <srv service='name' protocol='tcp'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlout/nat-network-dns-srv-record.xml
+++ b/tests/networkxml2xmlout/nat-network-dns-srv-record.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10' />
+    <srv service='name' protocol='tcp' domain='test-domain-name' target='.' port='1024' priority='10' weight='10'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlout/nat-network-dns-txt-record.xml
+++ b/tests/networkxml2xmlout/nat-network-dns-txt-record.xml
@@ -4,15 +4,15 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <dns>
-    <txt name='example' value='example value' />
+    <txt name='example' value='example value'/>
  </dns>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlout/nat-network.xml
+++ b/tests/networkxml2xmlout/nat-network.xml
@@ -4,12 +4,12 @@
  <forward dev='eth1' mode='nat'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr0' stp='on' delay='0' />
+  <bridge name='virbr0' stp='on' delay='0'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10' />
-      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <host mac='00:16:3e:77:e2:ed' name='a.example.com' ip='192.168.122.10'/>
+      <host mac='00:16:3e:3e:a9:1a' name='b.example.com' ip='192.168.122.11'/>
    </dhcp>
  </ip>
  <ip family='ipv4' address='192.168.123.1' netmask='255.255.255.0'>

--- a/tests/networkxml2xmlout/netboot-network.xml
+++ b/tests/networkxml2xmlout/netboot-network.xml
@@ -2,13 +2,13 @@
  <name>netboot</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='off' delay='1' />
+  <bridge name='virbr1' stp='off' delay='1'/>
  <domain name='example.com'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
-    <tftp root='/var/lib/tftproot' />
+    <tftp root='/var/lib/tftproot'/>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <bootp file='pxeboot.img' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <bootp file='pxeboot.img'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlout/netboot-proxy-network.xml
+++ b/tests/networkxml2xmlout/netboot-proxy-network.xml
@@ -2,12 +2,12 @@
  <name>netboot</name>
  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
  <forward mode='nat'/>
-  <bridge name='virbr1' stp='off' delay='1' />
+  <bridge name='virbr1' stp='off' delay='1'/>
  <domain name='example.com'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
    <dhcp>
-      <range start='192.168.122.2' end='192.168.122.254' />
-      <bootp file='pxeboot.img' server='10.20.30.40' />
+      <range start='192.168.122.2' end='192.168.122.254'/>
+      <bootp file='pxeboot.img' server='10.20.30.40'/>
    </dhcp>
  </ip>
 </network>
--- a/tests/networkxml2xmlout/routed-network.xml
+++ b/tests/networkxml2xmlout/routed-network.xml
@@ -4,7 +4,7 @@
  <forward dev='eth1' mode='route'>
    <interface dev='eth1'/>
  </forward>
-  <bridge name='virbr1' stp='on' delay='0' />
+  <bridge name='virbr1' stp='on' delay='0'/>
  <mac address='12:34:56:78:9a:bc'/>
  <ip address='192.168.122.1' netmask='255.255.255.0'>
  </ip>

--- a/tests/networkxml2xmltest.c
+++ b/tests/networkxml2xmltest.c
@@ -103,6 +103,8 @@ mymain(void)
    DO_TEST("netboot-network");
    DO_TEST("netboot-proxy-network");
    DO_TEST("nat-network-dns-txt-record");
+    DO_TEST("nat-network-dns-srv-record");
+    DO_TEST("nat-network-dns-srv-record-minimal");
    DO_TEST("nat-network-dns-hosts");
    DO_TEST("nat-network-dns-forward-plain");
    DO_TEST("8021Qbh-net");