提交 d3e43bad 编写于 作者: D David Allan

Fix device destroy return value

* Set return value in error cases
* Clarify error message when parent device is not vport capable
上级 a5b7965a
......@@ -1308,7 +1308,7 @@ virNodeDeviceGetParentHost(const virNodeDeviceObjListPtr devs,
parent = virNodeDeviceFindByName(devs, parent_name);
if (parent == NULL) {
virNodeDeviceReportError(VIR_ERR_INTERNAL_ERROR,
_("Could not find parent HBA for '%s'"),
_("Could not find parent device for '%s'"),
dev_name);
ret = -1;
goto out;
......@@ -1328,7 +1328,7 @@ virNodeDeviceGetParentHost(const virNodeDeviceObjListPtr devs,
if (cap == NULL) {
virNodeDeviceReportError(VIR_ERR_INTERNAL_ERROR,
_("Parent HBA %s is not capable "
_("Parent device %s is not capable "
"of vport operations"),
parent->def->name);
ret = -1;
......
......@@ -584,7 +584,7 @@ cleanup:
static int
nodeDeviceDestroy(virNodeDevicePtr dev)
{
int ret = 0;
int ret = -1;
virDeviceMonitorStatePtr driver = dev->conn->devMonPrivateData;
virNodeDeviceObjPtr obj = NULL;
char *parent_name = NULL, *wwnn = NULL, *wwpn = NULL;
......@@ -631,6 +631,7 @@ nodeDeviceDestroy(virNodeDevicePtr dev)
goto out;
}
ret = 0;
out:
if (obj)
virNodeDeviceObjUnlock(obj);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册