Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openeuler
libvirt
提交
d27160bb
L
libvirt
项目概览
openeuler
/
libvirt
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
L
libvirt
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d27160bb
编写于
6月 02, 2015
作者:
A
Andrea Bolognani
提交者:
John Ferlan
6月 02, 2015
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
virsh: Use standard error messages in vshCommandOptTimeoutToMs()
I missed this in the first time around, thanks Michal for noticing.
上级
779457a1
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
12 addition
and
8 deletion
+12
-8
tests/virsh-optparse
tests/virsh-optparse
+6
-6
tools/virsh.c
tools/virsh.c
+6
-2
未找到文件。
tests/virsh-optparse
浏览文件 @
d27160bb
...
@@ -257,7 +257,7 @@ test -s err && fail=1
...
@@ -257,7 +257,7 @@ test -s err && fail=1
# Non-numeric value
# Non-numeric value
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
invalid timeout
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
abc
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
abc
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
@@ -266,7 +266,7 @@ compare exp-err err || fail=1
...
@@ -266,7 +266,7 @@ compare exp-err err || fail=1
# Numeric value that's too big to be converted to ms and still
# Numeric value that's too big to be converted to ms and still
# fit inside an int
# fit inside an int
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
timeout is too big
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
2147484
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
2147484
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
@@ -274,7 +274,7 @@ compare exp-err err || fail=1
...
@@ -274,7 +274,7 @@ compare exp-err err || fail=1
# Numeric value with invalid suffix
# Numeric value with invalid suffix
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
invalid timeout
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
42WB
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
42WB
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
@@ -283,7 +283,7 @@ compare exp-err err || fail=1
...
@@ -283,7 +283,7 @@ compare exp-err err || fail=1
# Numeric value with valid suffix. Suffixes are not supported for
# Numeric value with valid suffix. Suffixes are not supported for
# the <timeout> option, so this value is rejected
# the <timeout> option, so this value is rejected
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
invalid timeout
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
42MB
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
42MB
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
@@ -291,7 +291,7 @@ compare exp-err err || fail=1
...
@@ -291,7 +291,7 @@ compare exp-err err || fail=1
# Negative value
# Negative value
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
invalid timeout
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
-1
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
-1
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
@@ -300,7 +300,7 @@ compare exp-err err || fail=1
...
@@ -300,7 +300,7 @@ compare exp-err err || fail=1
# Zero. This is not a valid timeout, but the value is parsed
# Zero. This is not a valid timeout, but the value is parsed
# correctly
# correctly
cat
<<
\
EOF
> exp-err || framework_failure
cat
<<
\
EOF
> exp-err || framework_failure
error:
invalid timeout
error:
Numeric value for <timeout> option is malformed or out of range
EOF
EOF
virsh
-q
-c
$test_url
event
--all
--timeout
0
>
out 2>err
&&
fail
=
1
virsh
-q
-c
$test_url
event
--all
--timeout
0
>
out 2>err
&&
fail
=
1
test
-s
out
&&
fail
=
1
test
-s
out
&&
fail
=
1
...
...
tools/virsh.c
浏览文件 @
d27160bb
...
@@ -1869,13 +1869,17 @@ vshCommandOptTimeoutToMs(vshControl *ctl, const vshCmd *cmd, int *timeout)
...
@@ -1869,13 +1869,17 @@ vshCommandOptTimeoutToMs(vshControl *ctl, const vshCmd *cmd, int *timeout)
int
rv
=
vshCommandOptInt
(
cmd
,
"timeout"
,
timeout
);
int
rv
=
vshCommandOptInt
(
cmd
,
"timeout"
,
timeout
);
if
(
rv
<
0
||
(
rv
>
0
&&
*
timeout
<
1
))
{
if
(
rv
<
0
||
(
rv
>
0
&&
*
timeout
<
1
))
{
vshError
(
ctl
,
"%s"
,
_
(
"invalid timeout"
));
vshError
(
ctl
,
_
(
"Numeric value for <%s> option is malformed or out of range"
),
"timeout"
);
return
-
1
;
return
-
1
;
}
}
if
(
rv
>
0
)
{
if
(
rv
>
0
)
{
/* Ensure that we can multiply by 1000 without overflowing. */
/* Ensure that we can multiply by 1000 without overflowing. */
if
(
*
timeout
>
INT_MAX
/
1000
)
{
if
(
*
timeout
>
INT_MAX
/
1000
)
{
vshError
(
ctl
,
"%s"
,
_
(
"timeout is too big"
));
vshError
(
ctl
,
_
(
"Numeric value for <%s> option is malformed or out of range"
),
"timeout"
);
return
-
1
;
return
-
1
;
}
}
*
timeout
*=
1000
;
*
timeout
*=
1000
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录