提交 cebb110f 编写于 作者: J Jiri Denemark

qemu: Cancel storage migration in parallel

Instead of cancelling disk mirrors sequentially, let's just call
block-job-cancel for all migrating disks and then wait until all
disappear.

In case we cancel disk mirrors at the end of successful migration we
also need to check all block jobs completed successfully. Otherwise we
have to abort the migration.
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
上级 4172b96a
...@@ -1793,76 +1793,122 @@ qemuMigrationDriveMirrorReady(virQEMUDriverPtr driver, ...@@ -1793,76 +1793,122 @@ qemuMigrationDriveMirrorReady(virQEMUDriverPtr driver,
} }
/** /*
* qemuMigrationCancelOneDriveMirror: * If @check is true, the function will report an error and return a different
* @driver: qemu driver * code in case a block job fails. This way we can properly abort migration in
* @vm: domain * case some block jobs failed once all memory has already been transferred.
*
* Cancel all drive-mirrors started by qemuMigrationDriveMirror.
* Any pending block job events for the mirrored disks will be
* processed.
* *
* Returns 0 on success, -1 otherwise. * Returns 1 if all mirrors are gone,
* 0 if some mirrors are still active,
* -1 some mirrors failed but some are still active,
* -2 all mirrors are gone but some of them failed.
*/ */
static int static int
qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver, qemuMigrationDriveMirrorCancelled(virQEMUDriverPtr driver,
virDomainObjPtr vm, virDomainObjPtr vm,
virDomainDiskDefPtr disk) bool check)
{ {
qemuDomainObjPrivatePtr priv = vm->privateData; size_t i;
char *diskAlias = NULL; size_t active = 0;
int ret = -1; int status;
bool failed = false;
/* No need to cancel if mirror already aborted */
if (disk->mirrorState == VIR_DOMAIN_DISK_MIRROR_STATE_ABORT) {
ret = 0;
} else {
virConnectDomainEventBlockJobStatus status = -1;
if (virAsprintf(&diskAlias, "%s%s",
QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0)
goto cleanup;
if (qemuDomainObjEnterMonitorAsync(driver, vm, for (i = 0; i < vm->def->ndisks; i++) {
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0) virDomainDiskDefPtr disk = vm->def->disks[i];
goto endjob; qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
ret = qemuMonitorBlockJobCancel(priv->mon, diskAlias, true);
if (qemuDomainObjExitMonitor(driver, vm) < 0)
goto endjob;
if (ret < 0) { if (!diskPriv->migrating)
virDomainBlockJobInfo info; continue;
/* block-job-cancel can fail if QEMU simultaneously status = qemuBlockJobUpdate(driver, vm, disk);
* aborted the job; probe for it again to detect this */ switch (status) {
if (qemuMonitorBlockJobInfo(priv->mon, diskAlias, case VIR_DOMAIN_BLOCK_JOB_FAILED:
&info, NULL) == 0) { if (check) {
ret = 0;
} else {
virReportError(VIR_ERR_OPERATION_FAILED, virReportError(VIR_ERR_OPERATION_FAILED,
_("could not cancel migration of disk %s"), _("migration of disk %s failed"),
disk->dst); disk->dst);
failed = true;
} }
/* fallthrough */
case VIR_DOMAIN_BLOCK_JOB_CANCELED:
case VIR_DOMAIN_BLOCK_JOB_COMPLETED:
qemuBlockJobSyncEnd(driver, vm, disk);
diskPriv->migrating = false;
break;
goto endjob; default:
active++;
} }
}
/* Mirror may become ready before cancellation takes if (failed) {
* effect; loop if we get that event first */ if (active) {
while (1) { VIR_DEBUG("Some disk mirrors failed; still waiting for %zu "
status = qemuBlockJobUpdate(driver, vm, disk); "disk mirrors to finish", active);
if (status != -1 && status != VIR_DOMAIN_BLOCK_JOB_READY) return -1;
break; } else {
if ((ret = virDomainObjWait(vm)) < 0) VIR_DEBUG("All disk mirrors are gone; some of them failed");
goto endjob; return -2;
}
} else {
if (active) {
VIR_DEBUG("Waiting for %zu disk mirrors to finish", active);
return 0;
} else {
VIR_DEBUG("All disk mirrors are gone");
return 1;
} }
} }
}
endjob:
qemuBlockJobSyncEnd(driver, vm, disk);
if (disk->mirrorState == VIR_DOMAIN_DISK_MIRROR_STATE_ABORT) /*
disk->mirrorState = VIR_DOMAIN_DISK_MIRROR_STATE_NONE; * Returns 0 on success,
* 1 when job is already completed or it failed and failNoJob is false,
* -1 on error or when job failed and failNoJob is true.
*/
static int
qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver,
virDomainObjPtr vm,
virDomainDiskDefPtr disk,
bool failNoJob)
{
qemuDomainObjPrivatePtr priv = vm->privateData;
char *diskAlias = NULL;
int ret = -1;
int status;
int rv;
status = qemuBlockJobUpdate(driver, vm, disk);
switch (status) {
case VIR_DOMAIN_BLOCK_JOB_FAILED:
case VIR_DOMAIN_BLOCK_JOB_CANCELED:
if (failNoJob) {
virReportError(VIR_ERR_OPERATION_FAILED,
_("migration of disk %s failed"),
disk->dst);
return -1;
}
return 1;
case VIR_DOMAIN_BLOCK_JOB_COMPLETED:
return 1;
}
if (virAsprintf(&diskAlias, "%s%s",
QEMU_DRIVE_HOST_PREFIX, disk->info.alias) < 0)
return -1;
if (qemuDomainObjEnterMonitorAsync(driver, vm,
QEMU_ASYNC_JOB_MIGRATION_OUT) < 0)
goto cleanup;
rv = qemuMonitorBlockJobCancel(priv->mon, diskAlias, true);
if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0)
goto cleanup;
ret = 0;
cleanup: cleanup:
VIR_FREE(diskAlias); VIR_FREE(diskAlias);
...@@ -1874,6 +1920,7 @@ qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver, ...@@ -1874,6 +1920,7 @@ qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver,
* qemuMigrationCancelDriveMirror: * qemuMigrationCancelDriveMirror:
* @driver: qemu driver * @driver: qemu driver
* @vm: domain * @vm: domain
* @check: if true report an error when some of the mirrors fails
* *
* Cancel all drive-mirrors started by qemuMigrationDriveMirror. * Cancel all drive-mirrors started by qemuMigrationDriveMirror.
* Any pending block job events for the affected disks will be * Any pending block job events for the affected disks will be
...@@ -1883,28 +1930,53 @@ qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver, ...@@ -1883,28 +1930,53 @@ qemuMigrationCancelOneDriveMirror(virQEMUDriverPtr driver,
*/ */
static int static int
qemuMigrationCancelDriveMirror(virQEMUDriverPtr driver, qemuMigrationCancelDriveMirror(virQEMUDriverPtr driver,
virDomainObjPtr vm) virDomainObjPtr vm,
bool check)
{ {
virErrorPtr err = NULL; virErrorPtr err = NULL;
int ret = 0; int ret = -1;
size_t i; size_t i;
int rv;
bool failed = false;
VIR_DEBUG("Cancelling drive mirrors for domain %s", vm->def->name);
for (i = 0; i < vm->def->ndisks; i++) { for (i = 0; i < vm->def->ndisks; i++) {
virDomainDiskDefPtr disk = vm->def->disks[i]; virDomainDiskDefPtr disk = vm->def->disks[i];
qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk); qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
if (!diskPriv->migrating || !diskPriv->blockJobSync) if (!diskPriv->migrating)
continue; continue;
if (qemuMigrationCancelOneDriveMirror(driver, vm, disk) < 0) { rv = qemuMigrationCancelOneDriveMirror(driver, vm, disk, check);
ret = -1; if (rv != 0) {
if (!err) if (rv < 0) {
err = virSaveLastError(); if (!err)
err = virSaveLastError();
failed = true;
}
qemuBlockJobSyncEnd(driver, vm, disk);
diskPriv->migrating = false;
}
}
while ((rv = qemuMigrationDriveMirrorCancelled(driver, vm, check)) != 1) {
if (rv < 0) {
failed = true;
if (rv == -2)
break;
} }
diskPriv->migrating = false; if (failed && !err)
err = virSaveLastError();
if (virDomainObjWait(vm) < 0)
goto cleanup;
} }
ret = failed ? -1 : 0;
cleanup:
if (err) { if (err) {
virSetError(err); virSetError(err);
virFreeError(err); virFreeError(err);
...@@ -3610,7 +3682,7 @@ qemuMigrationConfirmPhase(virQEMUDriverPtr driver, ...@@ -3610,7 +3682,7 @@ qemuMigrationConfirmPhase(virQEMUDriverPtr driver,
virErrorPtr orig_err = virSaveLastError(); virErrorPtr orig_err = virSaveLastError();
/* cancel any outstanding NBD jobs */ /* cancel any outstanding NBD jobs */
qemuMigrationCancelDriveMirror(driver, vm); qemuMigrationCancelDriveMirror(driver, vm, false);
virSetError(orig_err); virSetError(orig_err);
virFreeError(orig_err); virFreeError(orig_err);
...@@ -4196,7 +4268,7 @@ qemuMigrationRun(virQEMUDriverPtr driver, ...@@ -4196,7 +4268,7 @@ qemuMigrationRun(virQEMUDriverPtr driver,
/* cancel any outstanding NBD jobs */ /* cancel any outstanding NBD jobs */
if (mig && mig->nbd) { if (mig && mig->nbd) {
if (qemuMigrationCancelDriveMirror(driver, vm) < 0) if (qemuMigrationCancelDriveMirror(driver, vm, ret == 0) < 0)
ret = -1; ret = -1;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册