提交 cb022152 编写于 作者: J Ján Tomko 提交者: Osier Yang

nwfilter: fix NULL pointer check in virNWFilterSnoopReqNew

This can't lead to a crash since virNWFilterSnoopReqNew is only called
with a static array as the argument, but if we check for NULL we should
do it right.
上级 d3337028
...@@ -573,12 +573,12 @@ virNWFilterSnoopReqNew(const char *ifkey) ...@@ -573,12 +573,12 @@ virNWFilterSnoopReqNew(const char *ifkey)
{ {
virNWFilterSnoopReqPtr req; virNWFilterSnoopReqPtr req;
if (ifkey == NULL || strlen(ifkey) != VIR_IFKEY_LEN - 1) { if (ifkey == NULL || (ifkey && (strlen(ifkey) != VIR_IFKEY_LEN - 1))) {
virReportError(VIR_ERR_INTERNAL_ERROR, virReportError(VIR_ERR_INTERNAL_ERROR,
_("virNWFilterSnoopReqNew called with invalid " _("virNWFilterSnoopReqNew called with invalid "
"key \"%s\" (%zu)"), "key \"%s\" (%zu)"),
ifkey ? ifkey : "", ifkey ? ifkey : "",
strlen(ifkey)); ifkey ? strlen(ifkey) : 0);
return NULL; return NULL;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册