提交 ca9a94a0 编写于 作者: P Peter Krempa

vbox: snapshot: Avoid memleak in virVBoxSnapshotConfAllChildren

On re-allocation failure the function would leak already allocated
memory.
上级 810eea71
......@@ -477,24 +477,32 @@ virVBoxSnapshotConfAllChildren(virVBoxSnapshotConfHardDiskPtr disk,
virVBoxSnapshotConfHardDiskPtr *tempList = NULL;
size_t i = 0;
size_t j = 0;
if (VIR_ALLOC_N(ret, 0) < 0)
return 0;
for (i = 0; i < disk->nchildren; i++) {
tempSize = virVBoxSnapshotConfAllChildren(disk->children[i], &tempList);
if (VIR_EXPAND_N(ret, returnSize, tempSize) < 0)
return 0;
goto error;
for (j = 0; j < tempSize; j++) {
for (j = 0; j < tempSize; j++)
ret[returnSize - tempSize + j] = tempList[j];
}
VIR_FREE(tempList);
}
if (VIR_EXPAND_N(ret, returnSize, 1) < 0)
return 0;
goto error;
ret[returnSize - 1] = disk;
*list = ret;
return returnSize;
error:
VIR_FREE(tempList);
VIR_FREE(ret);
return 0;
}
void
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册