Allow trailing ',' in lists, and '_' in names

ChangeLog

+Sun Sep  3 12:50:12 EDT 2006 Daniel Berrange <berrange@redhat.com>
+
+	* src/conf.c: Allow '_' in variable names, and don't fail if there
+	is a trailing ',' at the end of a list.
+	* tests/confdata/fc4.conf, tests/confdata/fc4.out: Expand test 
+	config to include a '_' in a name, and a trailing ',' in a list.
+	
 Sun Sep  3 12:47:42 EDT 2006 Daniel Berrange <berrange@redhat.com>
 
 	* tests/.cvsignore, tests/confdata/.cvsignore: Ignore autogenerated

src/conf.c

@@ -443,6 +443,9 @@ virConfParseValue(virConfParserCtxtPtr ctxt)
 	    }
 	    NEXT;
 	    SKIP_BLANKS;
+	    if (CUR == ']') {
+	        break;
+	    }
 	    tmp = virConfParseValue(ctxt);
 	    if (tmp == NULL) {
 	        virConfFreeList(lst);
@@ -508,7 +511,7 @@ virConfParseName(virConfParserCtxtPtr ctxt)
         virConfError(NULL, VIR_ERR_CONF_SYNTAX, "expecting a name", ctxt->line);
 	return(NULL);
     }
-    while ((ctxt->cur < ctxt->end) && ((IS_CHAR(CUR)) || (IS_DIGIT(CUR))))
+    while ((ctxt->cur < ctxt->end) && ((IS_CHAR(CUR)) || (IS_DIGIT(CUR)) || (CUR == '_')))
         NEXT;
     ret = strndup(base, ctxt->cur - base);
     if (ret == NULL) {

tests/confdata/fc4.conf

@@ -2,9 +2,10 @@ kernel="/boot/vmlinuz-2.6.15-1.2054_FC5xenU"
 ramdisk="/boot/initrd-2.6.15-1.2054_FC5xenU.img"
 memory=128 # should be enough
 name="fc4"
-vif = [ 'mac=aa:00:00:00:00:11, bridge=xenbr0' ]
+vif = [ 'mac=aa:00:00:00:00:11, bridge=xenbr0', ]
 disk = ['file:/xen/fc4.img,sda1,w']
 root = "/dev/sda1"
 extra = "ro selinux=0 3"
+on_reboot   = 'restart'
 # just for testing ...
 tst = [ 1, 2, [ 3, 4 ], 5]

tests/confdata/fc4.out

@@ -6,5 +6,6 @@ vif = [ "mac=aa:00:00:00:00:11, bridge=xenbr0" ]
 disk = [ "file:/xen/fc4.img,sda1,w" ]
 root = "/dev/sda1"
 extra = "ro selinux=0 3"
+on_reboot = "restart"
 # just for testing ...
 tst = [ 1, 2, [ 3, 4 ], 5 ]