提交 c4d6a121 编写于 作者: L Laine Stump

qemu_hotplug: rename dev to match in qemuDomainDetachDeviceLive

I'm about to add a second virDomainDeviceDef to this function that
will point to the actual device in the domain object. while this is
just a partially filled-in example of what to look for. Naming it
match will make the code easier to follow.
Signed-off-by: NLaine Stump <laine@laine.org>
ACKed-by: NPeter Krempa <pkrempa@redhat.com>
上级 637d72f9
...@@ -6182,52 +6182,52 @@ qemuDomainDetachLease(virQEMUDriverPtr driver, ...@@ -6182,52 +6182,52 @@ qemuDomainDetachLease(virQEMUDriverPtr driver,
int int
qemuDomainDetachDeviceLive(virDomainObjPtr vm, qemuDomainDetachDeviceLive(virDomainObjPtr vm,
virDomainDeviceDefPtr dev, virDomainDeviceDefPtr match,
virQEMUDriverPtr driver, virQEMUDriverPtr driver,
bool async) bool async)
{ {
int ret = -1; int ret = -1;
switch ((virDomainDeviceType)dev->type) { switch ((virDomainDeviceType)match->type) {
case VIR_DOMAIN_DEVICE_DISK: case VIR_DOMAIN_DEVICE_DISK:
ret = qemuDomainDetachDeviceDiskLive(driver, vm, dev, async); ret = qemuDomainDetachDeviceDiskLive(driver, vm, match, async);
break; break;
case VIR_DOMAIN_DEVICE_CONTROLLER: case VIR_DOMAIN_DEVICE_CONTROLLER:
ret = qemuDomainDetachControllerDevice(driver, vm, dev, async); ret = qemuDomainDetachControllerDevice(driver, vm, match, async);
break; break;
case VIR_DOMAIN_DEVICE_LEASE: case VIR_DOMAIN_DEVICE_LEASE:
ret = qemuDomainDetachLease(driver, vm, dev->data.lease); ret = qemuDomainDetachLease(driver, vm, match->data.lease);
break; break;
case VIR_DOMAIN_DEVICE_NET: case VIR_DOMAIN_DEVICE_NET:
ret = qemuDomainDetachNetDevice(driver, vm, dev, async); ret = qemuDomainDetachNetDevice(driver, vm, match, async);
break; break;
case VIR_DOMAIN_DEVICE_HOSTDEV: case VIR_DOMAIN_DEVICE_HOSTDEV:
ret = qemuDomainDetachHostDevice(driver, vm, dev, async); ret = qemuDomainDetachHostDevice(driver, vm, match, async);
break; break;
case VIR_DOMAIN_DEVICE_CHR: case VIR_DOMAIN_DEVICE_CHR:
ret = qemuDomainDetachChrDevice(driver, vm, dev->data.chr, async); ret = qemuDomainDetachChrDevice(driver, vm, match->data.chr, async);
break; break;
case VIR_DOMAIN_DEVICE_RNG: case VIR_DOMAIN_DEVICE_RNG:
ret = qemuDomainDetachRNGDevice(driver, vm, dev->data.rng, async); ret = qemuDomainDetachRNGDevice(driver, vm, match->data.rng, async);
break; break;
case VIR_DOMAIN_DEVICE_MEMORY: case VIR_DOMAIN_DEVICE_MEMORY:
ret = qemuDomainDetachMemoryDevice(driver, vm, dev->data.memory, async); ret = qemuDomainDetachMemoryDevice(driver, vm, match->data.memory, async);
break; break;
case VIR_DOMAIN_DEVICE_SHMEM: case VIR_DOMAIN_DEVICE_SHMEM:
ret = qemuDomainDetachShmemDevice(driver, vm, dev->data.shmem, async); ret = qemuDomainDetachShmemDevice(driver, vm, match->data.shmem, async);
break; break;
case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_WATCHDOG:
ret = qemuDomainDetachWatchdog(driver, vm, dev->data.watchdog, async); ret = qemuDomainDetachWatchdog(driver, vm, match->data.watchdog, async);
break; break;
case VIR_DOMAIN_DEVICE_INPUT: case VIR_DOMAIN_DEVICE_INPUT:
ret = qemuDomainDetachInputDevice(vm, dev->data.input, async); ret = qemuDomainDetachInputDevice(vm, match->data.input, async);
break; break;
case VIR_DOMAIN_DEVICE_REDIRDEV: case VIR_DOMAIN_DEVICE_REDIRDEV:
ret = qemuDomainDetachRedirdevDevice(driver, vm, dev->data.redirdev, async); ret = qemuDomainDetachRedirdevDevice(driver, vm, match->data.redirdev, async);
break; break;
case VIR_DOMAIN_DEVICE_VSOCK: case VIR_DOMAIN_DEVICE_VSOCK:
ret = qemuDomainDetachVsockDevice(vm, dev->data.vsock, async); ret = qemuDomainDetachVsockDevice(vm, match->data.vsock, async);
break; break;
case VIR_DOMAIN_DEVICE_FS: case VIR_DOMAIN_DEVICE_FS:
...@@ -6245,7 +6245,7 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, ...@@ -6245,7 +6245,7 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm,
case VIR_DOMAIN_DEVICE_LAST: case VIR_DOMAIN_DEVICE_LAST:
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
_("live detach of device '%s' is not supported"), _("live detach of device '%s' is not supported"),
virDomainDeviceTypeToString(dev->type)); virDomainDeviceTypeToString(match->type));
break; break;
} }
......
...@@ -115,7 +115,7 @@ int qemuDomainAttachRNGDevice(virQEMUDriverPtr driver, ...@@ -115,7 +115,7 @@ int qemuDomainAttachRNGDevice(virQEMUDriverPtr driver,
virDomainRNGDefPtr rng); virDomainRNGDefPtr rng);
int qemuDomainDetachDeviceLive(virDomainObjPtr vm, int qemuDomainDetachDeviceLive(virDomainObjPtr vm,
virDomainDeviceDefPtr dev, virDomainDeviceDefPtr match,
virQEMUDriverPtr driver, virQEMUDriverPtr driver,
bool async); bool async);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册