提交 bf02b123 编写于 作者: D Daniel P. Berrange

rotatingfile: mark log files as close-on-exec

The log file descriptor associated with the virRotatingFile
struct should be marked close-on-exec, as even when virtlogd
re-exec's itself it expect to open the log file fresh. It
does not need to preserve the logfile handles, only the network
client FDs.
Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
上级 a8bb330f
......@@ -108,7 +108,7 @@ virRotatingFileWriterEntryNew(const char *path,
if (VIR_ALLOC(entry) < 0)
return NULL;
if ((entry->fd = open(path, O_CREAT|O_APPEND|O_WRONLY, mode)) < 0) {
if ((entry->fd = open(path, O_CREAT|O_APPEND|O_WRONLY|O_CLOEXEC, mode)) < 0) {
virReportSystemError(errno,
_("Unable to open file: %s"), path);
goto error;
......@@ -151,7 +151,7 @@ virRotatingFileReaderEntryNew(const char *path)
if (VIR_ALLOC(entry) < 0)
return NULL;
if ((entry->fd = open(path, O_RDONLY)) < 0) {
if ((entry->fd = open(path, O_RDONLY|O_CLOEXEC)) < 0) {
if (errno != ENOENT) {
virReportSystemError(errno,
_("Unable to open file: %s"), path);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册