提交 b97839b8 编写于 作者: J Jiri Denemark

cpu_x86: Fix memory leak in virCPUx86Translate

virCPUDefStealModel is called with keepVendor == true which means the
cpu structure will keep its original vendor/vendor_id values. Thus it
makes no sense to copy them to the translated definition as they won't
be used there anyway. Except that the translated->vendor pointer might
get lost in x86Decode.
Signed-off-by: NJiri Denemark <jdenemar@redhat.com>
上级 eda4ec94
......@@ -2709,10 +2709,6 @@ virCPUx86Translate(virCPUDefPtr cpu,
if (!(translated = virCPUDefCopyWithoutModel(cpu)))
goto cleanup;
if (VIR_STRDUP(translated->vendor, cpu->vendor) < 0 ||
VIR_STRDUP(translated->vendor_id, cpu->vendor_id) < 0)
goto cleanup;
if (x86Decode(translated, &model->data, models, nmodels, NULL, 0) < 0)
goto cleanup;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册