提交 b7e92024 编写于 作者: M Michal Privoznik

network: Set to NULL after virNetworkDefFree()

which frees all allocated memory but doesn't set the passed pointer to
NULL.  Therefore, we must do it ourselves. This is causing actual
libvirtd crash: Basically, when doing 'virsh net-edit' the newDef should
be dropped.  And the memory is freed, indeed. However, the pointer is
not set to NULL but kept instead. And the next duo of calls 'virsh
net-start' and 'virsh net-destroy' starts the disaster. The latter one
does the same as 'virsh destroy'; it sees that newDef is nonNULL so it
replaces def with newDef (which has been freed already as said a few
lines above). Therefore any subsequent call accessing def will hit the ground.
上级 47a7b935
...@@ -260,8 +260,9 @@ virNetworkObjAssignDef(virNetworkObjPtr network, ...@@ -260,8 +260,9 @@ virNetworkObjAssignDef(virNetworkObjPtr network,
return -1; return -1;
} }
} else if (!live) { } else if (!live) {
virNetworkDefFree(network->newDef); /* should be unnecessary */ virNetworkDefFree(network->newDef);
virNetworkDefFree(network->def); virNetworkDefFree(network->def);
network->newDef = NULL;
network->def = def; network->def = def;
} else { } else {
virReportError(VIR_ERR_OPERATION_INVALID, virReportError(VIR_ERR_OPERATION_INVALID,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册