提交 b660238e 编写于 作者: M Michal Privoznik

virObjectEventNew: Use virObjectUnref() to free virObjectEvent

While no leak was observed yet, there might be one if
virObjectEventClass is ever derived from another class. Because
in that case plain VIR_FREE() will not call dispose() from parent
classes possibly leaking some memory.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
上级 b3df357d
...@@ -649,13 +649,9 @@ virObjectEventNew(virClassPtr klass, ...@@ -649,13 +649,9 @@ virObjectEventNew(virClassPtr klass,
event->eventID = eventID; event->eventID = eventID;
event->remoteID = -1; event->remoteID = -1;
if (VIR_STRDUP(event->meta.name, name) < 0) { if (VIR_STRDUP(event->meta.name, name) < 0 ||
VIR_FREE(event); VIR_STRDUP(event->meta.key, key) < 0) {
return NULL; virObjectUnref(event);
}
if (VIR_STRDUP(event->meta.key, key) < 0) {
VIR_FREE(event->meta.name);
VIR_FREE(event);
return NULL; return NULL;
} }
event->meta.id = id; event->meta.id = id;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册