提交 b0365052 编写于 作者: P Pavel Mores 提交者: Cole Robinson

qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot()

While at bugfixing, convert the whole function to the new-style memory
allocation handling.
Reviewed-by: NCole Robinson <crobinso@redhat.com>
Signed-off-by: NPavel Mores <pmores@redhat.com>
上级 b87cca75
......@@ -132,14 +132,13 @@ int
qemuMonitorTextCreateSnapshot(qemuMonitorPtr mon,
const char *name)
{
char *cmd = NULL;
char *reply = NULL;
int ret = -1;
g_autofree char *cmd = NULL;
g_autofree char *reply = NULL;
cmd = g_strdup_printf("savevm \"%s\"", name);
if (qemuMonitorJSONHumanCommand(mon, cmd, &reply))
goto cleanup;
return -1;
if (strstr(reply, "Error while creating snapshot") ||
strstr(reply, "Could not open VM state file") ||
......@@ -148,19 +147,14 @@ qemuMonitorTextCreateSnapshot(qemuMonitorPtr mon,
(strstr(reply, "Error") && strstr(reply, "while writing VM"))) {
virReportError(VIR_ERR_OPERATION_FAILED,
_("Failed to take snapshot: %s"), reply);
goto cleanup;
return -1;
} else if (strstr(reply, "No block device can accept snapshots")) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
_("this domain does not have a device to take snapshots"));
goto cleanup;
return -1;
}
ret = 0;
cleanup:
VIR_FREE(cmd);
VIR_FREE(reply);
return ret;
return 0;
}
int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册