提交 ad340f22 编写于 作者: A Andrea Bolognani

tests: Move code from DO_TEST() to doCapsTest()

This removes the awkard escaping and will allow us to perform
some more refactoring later on.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
Acked-by: NPeter Krempa <pkrempa@redhat.com>
上级 5a8ceba2
......@@ -176,6 +176,32 @@ testQemuCapsCopy(const void *opaque)
}
static int
doCapsTest(const char *base,
const char *archName,
testQemuDataPtr data)
{
VIR_AUTOFREE(char *) title = NULL;
VIR_AUTOFREE(char *) copyTitle = NULL;
if (virAsprintf(&title, "%s (%s)", base, archName) < 0 ||
virAsprintf(&copyTitle, "copy %s (%s)", base, archName) < 0) {
return -1;
}
data->base = base;
data->archName = archName;
if (virTestRun(title, testQemuCaps, data) < 0)
data->ret = -1;
if (virTestRun(copyTitle, testQemuCapsCopy, data) < 0)
data->ret = -1;
return 0;
}
static int
mymain(void)
{
......@@ -196,18 +222,8 @@ mymain(void)
#define DO_TEST(arch, name) \
do { \
VIR_AUTOFREE(char *) title = NULL; \
VIR_AUTOFREE(char *) copyTitle = NULL; \
if (virAsprintf(&title, "%s (%s)", name, arch) < 0 || \
virAsprintf(&copyTitle, "copy %s (%s)", name, arch) < 0) { \
return -EXIT_FAILURE; \
} \
data.archName = arch; \
data.base = name; \
if (virTestRun(title, testQemuCaps, &data) < 0) \
data.ret = -1; \
if (virTestRun(copyTitle, testQemuCapsCopy, &data) < 0) \
data.ret = -1; \
if (doCapsTest(name, arch, &data) < 0) \
return EXIT_FAILURE; \
} while (0)
/* Keep this in sync with qemucaps2xmltest */
......
......@@ -173,6 +173,25 @@ testQemuCapsXML(const void *opaque)
return ret;
}
static int
doCapsTest(const char *base,
const char *archName,
testQemuDataPtr data)
{
VIR_AUTOFREE(char *) title = NULL;
if (virAsprintf(&title, "%s (%s)", base, archName) < 0)
return -1;
data->base = base;
data->archName = archName;
if (virTestRun(title, testQemuCapsXML, data) < 0)
data->ret = -1;
return 0;
}
static int
mymain(void)
{
......@@ -193,13 +212,8 @@ mymain(void)
#define DO_TEST(arch, name) \
do { \
VIR_AUTOFREE(char *) title = NULL; \
if (virAsprintf(&title, "%s (%s)", name, arch) < 0) \
return -EXIT_FAILURE; \
data.archName = arch; \
data.base = name; \
if (virTestRun(title, testQemuCapsXML, &data) < 0) \
data.ret = -1; \
if (doCapsTest(name, arch, &data) < 0) \
return EXIT_FAILURE; \
} while (0)
/* Keep this in sync with qemucapabilitiestest */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册