提交 abddeb84 编写于 作者: J John Ferlan

vbox: Resolve Coverity UNUSED_VALUE

Handle a few places where Coverity complains about the value being
unused. For two of them (Close cases) - the comments above the close
indicate there is no harm to ignore the error - so added an ignore_value.
For the other condition, added an rc check like other callers.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
上级 8ea809df
......@@ -4345,6 +4345,11 @@ static int vboxCloseDisksRecursively(virDomainPtr dom, char *location)
PRUnichar *childLocationUtf = NULL;
char *childLocation = NULL;
rc = gVBoxAPI.UIMedium.GetLocation(childMedium, &childLocationUtf);
if (NS_FAILED(rc)) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Unable to get childMedium location"));
goto cleanup;
}
VBOX_UTF16_TO_UTF8(childLocationUtf, &childLocation);
VBOX_UTF16_FREE(childLocationUtf);
if (vboxCloseDisksRecursively(dom, childLocation) < 0) {
......@@ -4767,7 +4772,7 @@ vboxSnapshotRedefine(virDomainPtr dom,
* succeed, unless there is still another machine which uses the
* medium. No harm done if we ignore the error.
*/
rc = gVBoxAPI.UIMedium.Close(medium);
ignore_value(gVBoxAPI.UIMedium.Close(medium));
}
VBOX_UTF8_FREE(locationUtf8);
}
......@@ -6987,7 +6992,7 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapshotPtr snapshot)
* reference in a sane order, which means that closing will normally
* succeed, unless there is still another machine which uses the
* medium. No harm done if we ignore the error. */
rc = gVBoxAPI.UIMedium.Close(medium);
ignore_value(gVBoxAPI.UIMedium.Close(medium));
}
VBOX_UTF16_FREE(locationUtf16);
VBOX_UTF8_FREE(locationUtf8);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册