提交 a82c1821 编写于 作者: C Cole Robinson

qemu: monitor: cleanup loadvm error handling

Drop redundant NULL checks, add error string prefixes, consolidate
a few indentical reports.
Acked-by: NMichal Privoznik <mprivozn@redhat.com>
Signed-off-by: NCole Robinson <crobinso@redhat.com>
上级 e9d4912c
...@@ -215,28 +215,25 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) ...@@ -215,28 +215,25 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name)
if (qemuMonitorHMPCommand(mon, cmd, &reply)) if (qemuMonitorHMPCommand(mon, cmd, &reply))
goto cleanup; goto cleanup;
if (strstr(reply, "No block device supports snapshots") != NULL) { if (strstr(reply, "No block device supports snapshots")) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s", virReportError(VIR_ERR_OPERATION_INVALID, "%s",
_("this domain does not have a device to load snapshots")); _("this domain does not have a device to load snapshots"));
goto cleanup; goto cleanup;
} else if (strstr(reply, "Could not find snapshot") != NULL) { } else if (strstr(reply, "Could not find snapshot")) {
virReportError(VIR_ERR_OPERATION_INVALID, virReportError(VIR_ERR_OPERATION_INVALID,
_("the snapshot '%s' does not exist, and was not loaded"), _("the snapshot '%s' does not exist, and was not loaded"),
name); name);
goto cleanup; goto cleanup;
} else if (strstr(reply, "Snapshots not supported on device") != NULL) { } else if (strstr(reply, "Snapshots not supported on device")) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s", reply); virReportError(VIR_ERR_OPERATION_INVALID,
goto cleanup; _("Failed to load snapshot: %s"), reply);
} else if (strstr(reply, "Could not open VM state file") != NULL) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s", reply);
goto cleanup;
} else if (strstr(reply, "Error") != NULL
&& strstr(reply, "while loading VM state") != NULL) {
virReportError(VIR_ERR_OPERATION_FAILED, "%s", reply);
goto cleanup; goto cleanup;
} else if (strstr(reply, "Error") != NULL } else if (strstr(reply, "Could not open VM state file") ||
&& strstr(reply, "while activating snapshot on") != NULL) { (strstr(reply, "Error") &&
virReportError(VIR_ERR_OPERATION_FAILED, "%s", reply); (strstr(reply, "while loading VM state") ||
strstr(reply, "while activating snapshot on")))) {
virReportError(VIR_ERR_OPERATION_FAILED,
_("Failed to load snapshot: %s"), reply);
goto cleanup; goto cleanup;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册