Remove virConnectPtr from interface XML APIs

The virConnectPtr is no longer required for error reporting since
that is recorded in a thread local. Remove use of virConnectPtr
from all APIs in interface_conf.{h,c} and update all callers to
match

src/conf/interface_conf.h

@@ -193,22 +193,17 @@ void virInterfaceDefFree(virInterfaceDefPtr def);
 void virInterfaceObjFree(virInterfaceObjPtr iface);
 void virInterfaceObjListFree(virInterfaceObjListPtr vms);
 
-virInterfaceObjPtr virInterfaceAssignDef(virConnectPtr conn,
-                                         virInterfaceObjListPtr interfaces,
+virInterfaceObjPtr virInterfaceAssignDef(virInterfaceObjListPtr interfaces,
                                          const virInterfaceDefPtr def);
 void virInterfaceRemove(virInterfaceObjListPtr interfaces,
                         const virInterfaceObjPtr iface);
 
-virInterfaceDefPtr virInterfaceDefParseString(virConnectPtr conn,
-                                              const char *xmlStr);
-virInterfaceDefPtr virInterfaceDefParseFile(virConnectPtr conn,
-                                            const char *filename);
-virInterfaceDefPtr virInterfaceDefParseNode(virConnectPtr conn,
-                                            xmlDocPtr xml,
+virInterfaceDefPtr virInterfaceDefParseString(const char *xmlStr);
+virInterfaceDefPtr virInterfaceDefParseFile(const char *filename);
+virInterfaceDefPtr virInterfaceDefParseNode(xmlDocPtr xml,
                                             xmlNodePtr root);
 
-char *virInterfaceDefFormat(virConnectPtr conn,
-                            const virInterfaceDefPtr def);
+char *virInterfaceDefFormat(const virInterfaceDefPtr def);
 
 void virInterfaceObjLock(virInterfaceObjPtr obj);
 void virInterfaceObjUnlock(virInterfaceObjPtr obj);

src/interface/netcf_driver.c

@@ -356,13 +356,13 @@ static char *interfaceGetXMLDesc(virInterfacePtr ifinfo,
         goto cleanup;
     }
 
-    ifacedef = virInterfaceDefParseString(ifinfo->conn, xmlstr);
+    ifacedef = virInterfaceDefParseString(xmlstr);
     if (!ifacedef) {
         /* error was already reported */
         goto cleanup;
     }
 
-    ret = virInterfaceDefFormat(ifinfo->conn, ifacedef);
+    ret = virInterfaceDefFormat(ifacedef);
     if (!ret) {
         /* error was already reported */
         goto cleanup;
@@ -388,13 +388,13 @@ static virInterfacePtr interfaceDefineXML(virConnectPtr conn,
 
     interfaceDriverLock(driver);
 
-    ifacedef = virInterfaceDefParseString(conn, xml);
+    ifacedef = virInterfaceDefParseString(xml);
     if (!ifacedef) {
         /* error was already reported */
         goto cleanup;
     }
 
-    xmlstr = virInterfaceDefFormat(conn, ifacedef);
+    xmlstr = virInterfaceDefFormat(ifacedef);
     if (!xmlstr) {
         /* error was already reported */
         goto cleanup;

src/test/test_driver.c

@@ -568,9 +568,9 @@ static int testOpenDefault(virConnectPtr conn) {
     netobj->persistent = 1;
     virNetworkObjUnlock(netobj);
 
-    if (!(interfacedef = virInterfaceDefParseString(conn, defaultInterfaceXML)))
+    if (!(interfacedef = virInterfaceDefParseString(defaultInterfaceXML)))
         goto error;
-    if (!(interfaceobj = virInterfaceAssignDef(conn, &privconn->ifaces, interfacedef))) {
+    if (!(interfaceobj = virInterfaceAssignDef(&privconn->ifaces, interfacedef))) {
         virInterfaceDefFree(interfacedef);
         goto error;
     }
@@ -969,16 +969,16 @@ static int testOpenFromFile(virConnectPtr conn,
                 goto error;
             }
 
-            def = virInterfaceDefParseFile(conn, absFile);
+            def = virInterfaceDefParseFile(absFile);
             VIR_FREE(absFile);
             if (!def)
                 goto error;
         } else {
-            if ((def = virInterfaceDefParseNode(conn, xml, ifaces[i])) == NULL)
+            if ((def = virInterfaceDefParseNode(xml, ifaces[i])) == NULL)
                 goto error;
         }
 
-        if (!(iface = virInterfaceAssignDef(conn, &privconn->ifaces, def))) {
+        if (!(iface = virInterfaceAssignDef(&privconn->ifaces, def))) {
             virInterfaceDefFree(def);
             goto error;
         }
@@ -3328,7 +3328,7 @@ static char *testInterfaceGetXMLDesc(virInterfacePtr iface,
         goto cleanup;
     }
 
-    ret = virInterfaceDefFormat(iface->conn, privinterface->def);
+    ret = virInterfaceDefFormat(privinterface->def);
 
 cleanup:
     if (privinterface)
@@ -3346,10 +3346,10 @@ static virInterfacePtr testInterfaceDefineXML(virConnectPtr conn, const char *xm
     virInterfacePtr ret = NULL;
 
     testDriverLock(privconn);
-    if ((def = virInterfaceDefParseString(conn, xmlStr)) == NULL)
+    if ((def = virInterfaceDefParseString(xmlStr)) == NULL)
         goto cleanup;
 
-    if ((iface = virInterfaceAssignDef(conn, &privconn->ifaces, def)) == NULL)
+    if ((iface = virInterfaceAssignDef(&privconn->ifaces, def)) == NULL)
         goto cleanup;
     def = NULL;
 

tests/interfacexml2xmltest.c

@@ -29,10 +29,10 @@ static int testCompareXMLToXMLFiles(const char *xml) {
     if (virtTestLoadFile(xml, &xmlPtr, MAX_FILE) < 0)
         goto fail;
 
-    if (!(dev = virInterfaceDefParseString(NULL, xmlData)))
+    if (!(dev = virInterfaceDefParseString(xmlData)))
         goto fail;
 
-    if (!(actual = virInterfaceDefFormat(NULL, dev)))
+    if (!(actual = virInterfaceDefFormat(dev)))
         goto fail;
 
     if (STRNEQ(xmlData, actual)) {