提交 9a04cad0 编写于 作者: D Daniel P. Berrangé

libvirt: remove link to outdated mailing list post

The virConnectGetType() method has an unfortunate signature, returning a
static string that must not be freed by the caller. The remote driver,
however, gets this string dynamically over an RPC call, which raised a
design discussion on the mailing list. Eventually the problem was
resolved by having the remote driver cache the returned string
internally and free it when the connection was closed.

The link to the mailing list is thus talking about a problem that does
not actually exist in the final implementation, and at best serves to
confuse the reader into thinking there might be a memory leak.
Reviewed-by: NJán Tomko <jtomko@redhat.com>
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
上级 881686d4
...@@ -98,9 +98,6 @@ virConnectSupportsFeature(virConnectPtr conn, int feature) ...@@ -98,9 +98,6 @@ virConnectSupportsFeature(virConnectPtr conn, int feature)
* hypervisor, use virConnectGetCapabilities(). * hypervisor, use virConnectGetCapabilities().
* *
* Returns NULL in case of error, a static zero terminated string otherwise. * Returns NULL in case of error, a static zero terminated string otherwise.
*
* See also:
* http://www.redhat.com/archives/libvir-list/2007-February/msg00096.html
*/ */
const char * const char *
virConnectGetType(virConnectPtr conn) virConnectGetType(virConnectPtr conn)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册