提交 9741f346 编写于 作者: W Wen Congyang 提交者: Eric Blake

unlock the monitor when unwatching the monitor

Steps to reproduce this bug:
# virsh qemu-monitor-command domain 'cpu_set 2 online' --hmp
The domain has 2 cpus, and we try to set the third cpu online.
The qemu crashes, and this command will hang.

The reason is that the refs is not 1 when we unwatch the monitor.
We lock the monitor, but we do not unlock it. So virCondWait()
will be blocked.
Signed-off-by: NWen Congyang <wency@cn.fujitsu.com>
上级 838f6696
......@@ -239,7 +239,8 @@ qemuMonitorUnwatch(void *monitor)
qemuMonitorPtr mon = monitor;
qemuMonitorLock(mon);
qemuMonitorUnref(mon);
if (qemuMonitorUnref(mon) > 0)
qemuMonitorUnlock(mon);
}
static int
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册