Improve error message diagnosing incorrect XML CPU mode

Tell the user what CPU mode value is wrong

Improve error message diagnosing incorrect XML CPU mode
Tell the user what CPU mode value is wrong
92cbe7ae · Daniel P. Berrange · e0f0131d · 92cbe7ae
隐藏空白更改
内联并排

Showing with 5 addition and 3 deletion

src/conf/cpu_conf.c src/conf/cpu_conf.c +5 -3

未找到文件。
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -234,13 +234,15 @@ virCPUDefParseXML(const xmlNodePtr node,
            goto error;
        } else {
            def->mode = virCPUModeTypeFromString(cpuMode);
-            VIR_FREE(cpuMode);

            if (def->mode < 0) {
-                virCPUReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                                  _("Invalid mode attribute"));
+                virCPUReportError(VIR_ERR_INTERNAL_ERROR,
+                                  _("Invalid mode attribute '%s'"),
+                                  cpuMode);
+                VIR_FREE(cpuMode);
                goto error;
            }
+            VIR_FREE(cpuMode);
        }
    } else {
        if (def->type == VIR_CPU_TYPE_HOST)