提交 85394f67 编写于 作者: A Andrea Bolognani

tests: testQemuCapsIterate: Don't ignore malformed file names

If files whose name doesn't follow the expected format are added
to the repository, it's better to make the test suite fail than to
silently ignore them.
Signed-off-by: NAndrea Bolognani <abologna@redhat.com>
Reviewed-by: NJiri Denemark <jdenemar@redhat.com>
上级 dea6c109
......@@ -910,7 +910,7 @@ testQemuCapsIterate(const char *suffix,
goto cleanup;
while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH)) > 0) {
char *tmp = ent->d_name;
g_autofree char *tmp = g_strdup(ent->d_name);
char *base = NULL;
char *archName = NULL;
......@@ -918,9 +918,11 @@ testQemuCapsIterate(const char *suffix,
if (!virStringStripSuffix(tmp, suffix))
continue;
/* Find the last dot, moving on if none is present */
if (!(archName = strrchr(tmp, '.')))
continue;
/* Find the last dot */
if (!(archName = strrchr(tmp, '.'))) {
VIR_TEST_VERBOSE("malformed file name '%s'", ent->d_name);
goto cleanup;
}
/* The base name is everything before the last dot, and
* the architecture name everything after it */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册