提交 80fffee9 编写于 作者: J Ján Tomko

Don't check validity of missing attributes in DNS SRV XML

This fixes a crash if one of them is missing.

https://bugzilla.redhat.com/show_bug.cgi?id=988718
(cherry picked from commit 461fd86a)
上级 90688b14
......@@ -920,7 +920,7 @@ virNetworkDNSSrvDefParseXML(const char *networkName,
" of network %s"), networkName);
goto error;
}
if (strlen(def->service) > DNS_RECORD_LENGTH_SRV) {
if (def->service && strlen(def->service) > DNS_RECORD_LENGTH_SRV) {
virReportError(VIR_ERR_XML_DETAIL,
_("Service name '%s' in network %s is too long, limit is %d bytes"),
def->service, networkName, DNS_RECORD_LENGTH_SRV);
......@@ -936,7 +936,8 @@ virNetworkDNSSrvDefParseXML(const char *networkName,
}
/* Check whether protocol value is the supported one */
if (STRNEQ(def->protocol, "tcp") && (STRNEQ(def->protocol, "udp"))) {
if (def->protocol && STRNEQ(def->protocol, "tcp") &&
(STRNEQ(def->protocol, "udp"))) {
virReportError(VIR_ERR_XML_DETAIL,
_("Invalid protocol attribute value '%s' "
" in DNS SRV record of network %s"),
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册