提交 727a3c58 编写于 作者: J John Ferlan

Resolve a couple of memory leaks

Commit id '4b75237f' seems to have triggered Coverity into finding
at least one memory leak in xen_xl.c for error path for cleanup where
the listenAddr would be leaked. Reviewing other callers, it seems that
qemu_parse_command.c would have the same issue, so just it too.
上级 cb31d618
......@@ -500,6 +500,7 @@ qemuParseCommandLineVnc(virDomainDefPtr def,
{
int ret = -1;
virDomainGraphicsDefPtr vnc = NULL;
char *listenAddr = NULL;
char *tmp;
if (VIR_ALLOC(vnc) < 0)
......@@ -519,7 +520,6 @@ qemuParseCommandLineVnc(virDomainDefPtr def,
char *opts;
char *port;
const char *sep = ":";
char *listenAddr = NULL;
if (val[0] == '[')
sep = "]:";
tmp = strstr(val, sep);
......@@ -614,6 +614,7 @@ qemuParseCommandLineVnc(virDomainDefPtr def,
cleanup:
virDomainGraphicsDefFree(vnc);
VIR_FREE(listenAddr);
return ret;
}
......
......@@ -240,6 +240,7 @@ xenParseXLSpice(virConfPtr conf, virDomainDefPtr def)
return 0;
cleanup:
VIR_FREE(listenAddr);
virDomainGraphicsDefFree(graphics);
return -1;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册