提交 643b5f84 编写于 作者: J John Ferlan

virnetserverclient: Remove Coverity DEADCODE warning

The x509dname is only set inside a WITH_GNUTLS conditional, so
when used/check later on for NULL, Coverity detects this is not
possible.  Added WITH_GNUTLS around uses to remove message
上级 5a298ec0
......@@ -658,7 +658,9 @@ virNetServerClientCreateIdentity(virNetServerClientPtr client)
#if WITH_SASL
char *saslname = NULL;
#endif
#if WITH_GNUTLS
char *x509dname = NULL;
#endif
char *seccontext = NULL;
virIdentityPtr ret = NULL;
......@@ -748,11 +750,13 @@ virNetServerClientCreateIdentity(virNetServerClientPtr client)
saslname) < 0)
goto error;
#endif
#if WITH_GNUTLS
if (x509dname &&
virIdentitySetAttr(ret,
VIR_IDENTITY_ATTR_X509_DISTINGUISHED_NAME,
x509dname) < 0)
goto error;
#endif
if (seccontext &&
virIdentitySetAttr(ret,
VIR_IDENTITY_ATTR_SELINUX_CONTEXT,
......@@ -770,7 +774,9 @@ cleanup:
#if HAVE_SASL
VIR_FREE(saslname);
#endif
#if WITH_GNUTLS
VIR_FREE(x509dname);
#endif
return ret;
error:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册