Make RPC call dispatch threaded

ChangeLog

+Tue Jan 20 16:36:53 GMT 2009 Daniel P. Berrange <berrange@redhat.com>
+
+	Make RPC call dispatch threaded
+	* src/libvirt_private.syms, src/util.h, src/util.c: Add
+	a general virSetNonBlock() helper with portability to
+	Win32
+	* src/remote_internal.c: Re-factor I/O to allow RPC calls
+	from multiple threads to be handled concurrently.
+
 Tue Jan 20 17:08:20 CET 2009 Daniel Veillard <veillard@redhat.com>
 
 	* src/domain_conf.h src/lxc_driver.c src/uml_driver.c: virDomainObj

src/libvirt_private.syms

@@ -290,6 +290,7 @@ virEnumToString;
 virEventAddHandle;
 virEventRemoveHandle;
 virExec;
+virSetNonBlock;
 virFormatMacAddr;
 virGetHostname;
 virParseMacAddr;

src/util.c

@@ -34,6 +34,7 @@
 #include <poll.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/ioctl.h>
 #if HAVE_SYS_WAIT_H
 #include <sys/wait.h>
 #endif
@@ -155,25 +156,35 @@ virArgvToString(const char *const *argv)
     return ret;
 }
 
-
-#ifndef __MINGW32__
-
-static int virSetCloseExec(int fd) {
+int virSetNonBlock(int fd) {
+#ifndef WIN32
     int flags;
-    if ((flags = fcntl(fd, F_GETFD)) < 0)
+    if ((flags = fcntl(fd, F_GETFL)) < 0)
         return -1;
-    flags |= FD_CLOEXEC;
-    if ((fcntl(fd, F_SETFD, flags)) < 0)
+    flags |= O_NONBLOCK;
+    if ((fcntl(fd, F_SETFL, flags)) < 0)
         return -1;
+#else
+    unsigned long flag = 1;
+
+    /* This is actually Gnulib's replacement rpl_ioctl function.
+     * We can't call ioctlsocket directly in any case.
+     */
+    if (ioctl (fd, FIONBIO, (void *) &flag) == -1)
+        return -1;
+#endif
     return 0;
 }
 
-static int virSetNonBlock(int fd) {
+
+#ifndef WIN32
+
+static int virSetCloseExec(int fd) {
     int flags;
-    if ((flags = fcntl(fd, F_GETFL)) < 0)
+    if ((flags = fcntl(fd, F_GETFD)) < 0)
         return -1;
-    flags |= O_NONBLOCK;
-    if ((fcntl(fd, F_SETFL, flags)) < 0)
+    flags |= FD_CLOEXEC;
+    if ((fcntl(fd, F_SETFD, flags)) < 0)
         return -1;
     return 0;
 }

src/util.h

@@ -38,6 +38,8 @@ enum {
     VIR_EXEC_DAEMON = (1 << 1),
 };
 
+int virSetNonBlock(int fd);
+
 int virExec(virConnectPtr conn,
             const char *const*argv,
             const char *const*envp,