提交 5cb926f9 编写于 作者: J Ján Tomko

vboxDumpDisplay: reduce indentation level

Use STREQ_NULLABLE instead of deep nesting.
上级 2ea69405
...@@ -3321,54 +3321,53 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine) ...@@ -3321,54 +3321,53 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine)
if (valueTypeUtf16) { if (valueTypeUtf16) {
VBOX_UTF16_TO_UTF8(valueTypeUtf16, &valueTypeUtf8); VBOX_UTF16_TO_UTF8(valueTypeUtf16, &valueTypeUtf8);
VBOX_UTF16_FREE(valueTypeUtf16); VBOX_UTF16_FREE(valueTypeUtf16);
}
if (STREQ(valueTypeUtf8, "sdl") || STREQ(valueTypeUtf8, "gui")) { if (STREQ_NULLABLE(valueTypeUtf8, "sdl") ||
PRUnichar *keyDislpayUtf16 = NULL; STREQ_NULLABLE(valueTypeUtf8, "gui")) {
PRUnichar *valueDisplayUtf16 = NULL; PRUnichar *keyDislpayUtf16 = NULL;
char *valueDisplayUtf8 = NULL; PRUnichar *valueDisplayUtf16 = NULL;
char *valueDisplayUtf8 = NULL;
VBOX_UTF8_TO_UTF16("FRONTEND/Display", &keyDislpayUtf16); VBOX_UTF8_TO_UTF16("FRONTEND/Display", &keyDislpayUtf16);
gVBoxAPI.UIMachine.GetExtraData(machine, keyDislpayUtf16, &valueDisplayUtf16); gVBoxAPI.UIMachine.GetExtraData(machine, keyDislpayUtf16, &valueDisplayUtf16);
VBOX_UTF16_FREE(keyDislpayUtf16); VBOX_UTF16_FREE(keyDislpayUtf16);
if (valueDisplayUtf16) { if (valueDisplayUtf16) {
VBOX_UTF16_TO_UTF8(valueDisplayUtf16, &valueDisplayUtf8); VBOX_UTF16_TO_UTF8(valueDisplayUtf16, &valueDisplayUtf8);
VBOX_UTF16_FREE(valueDisplayUtf16); VBOX_UTF16_FREE(valueDisplayUtf16);
if (strlen(valueDisplayUtf8) <= 0) if (strlen(valueDisplayUtf8) <= 0)
VBOX_UTF8_FREE(valueDisplayUtf8); VBOX_UTF8_FREE(valueDisplayUtf8);
} }
if (STREQ(valueTypeUtf8, "sdl")) { if (STREQ(valueTypeUtf8, "sdl")) {
sdlPresent = 1; sdlPresent = 1;
if (VIR_STRDUP(sdlDisplay, valueDisplayUtf8) < 0) { if (VIR_STRDUP(sdlDisplay, valueDisplayUtf8) < 0) {
/* just don't go to cleanup yet as it is ok to have /* just don't go to cleanup yet as it is ok to have
* sdlDisplay as NULL and we check it below if it * sdlDisplay as NULL and we check it below if it
* exist and then only use it there * exist and then only use it there
*/ */
}
totalPresent++;
} }
totalPresent++;
}
if (STREQ(valueTypeUtf8, "gui")) { if (STREQ(valueTypeUtf8, "gui")) {
guiPresent = 1; guiPresent = 1;
if (VIR_STRDUP(guiDisplay, valueDisplayUtf8) < 0) { if (VIR_STRDUP(guiDisplay, valueDisplayUtf8) < 0) {
/* just don't go to cleanup yet as it is ok to have /* just don't go to cleanup yet as it is ok to have
* guiDisplay as NULL and we check it below if it * guiDisplay as NULL and we check it below if it
* exist and then only use it there * exist and then only use it there
*/ */
}
totalPresent++;
} }
VBOX_UTF8_FREE(valueDisplayUtf8); totalPresent++;
} }
VBOX_UTF8_FREE(valueDisplayUtf8);
if (STREQ(valueTypeUtf8, "vrdp"))
vrdpPresent = 1;
VBOX_UTF8_FREE(valueTypeUtf8);
} }
if (STREQ_NULLABLE(valueTypeUtf8, "vrdp"))
vrdpPresent = 1;
if ((totalPresent > 0) && (VIR_ALLOC_N(def->graphics, totalPresent) >= 0)) { if ((totalPresent > 0) && (VIR_ALLOC_N(def->graphics, totalPresent) >= 0)) {
if ((guiPresent) && (VIR_ALLOC(def->graphics[def->ngraphics]) >= 0)) { if ((guiPresent) && (VIR_ALLOC(def->graphics[def->ngraphics]) >= 0)) {
def->graphics[def->ngraphics]->type = VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP; def->graphics[def->ngraphics]->type = VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP;
...@@ -3441,6 +3440,8 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine) ...@@ -3441,6 +3440,8 @@ vboxDumpDisplay(virDomainDefPtr def, vboxGlobalData *data, IMachine *machine)
} }
VBOX_RELEASE(VRDxServer); VBOX_RELEASE(VRDxServer);
} }
VBOX_UTF8_FREE(valueTypeUtf8);
} }
static void static void
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册