提交 4fab1209 编写于 作者: M Martin Kletzander

Remove unnecessary curly brackets in rest of src/

Signed-off-by: NMartin Kletzander <mkletzan@redhat.com>
上级 8c38594b
...@@ -432,9 +432,8 @@ vmwareVmxPath(virDomainDefPtr vmdef, char **vmxPath) ...@@ -432,9 +432,8 @@ vmwareVmxPath(virDomainDefPtr vmdef, char **vmxPath)
goto cleanup; goto cleanup;
} }
if (vmwareParsePath(src, &directoryName, &fileName) < 0) { if (vmwareParsePath(src, &directoryName, &fileName) < 0)
goto cleanup; goto cleanup;
}
if (!virFileHasSuffix(fileName, ".vmdk")) { if (!virFileHasSuffix(fileName, ".vmdk")) {
virReportError(VIR_ERR_INTERNAL_ERROR, virReportError(VIR_ERR_INTERNAL_ERROR,
......
...@@ -313,9 +313,8 @@ vmwareStopVM(struct vmware_driver *driver, ...@@ -313,9 +313,8 @@ vmwareStopVM(struct vmware_driver *driver,
vmwareSetSentinal(cmd, vmwareDriverTypeToString(driver->type)); vmwareSetSentinal(cmd, vmwareDriverTypeToString(driver->type));
vmwareSetSentinal(cmd, ((vmwareDomainPtr) vm->privateData)->vmxPath); vmwareSetSentinal(cmd, ((vmwareDomainPtr) vm->privateData)->vmxPath);
if (virRun(cmd, NULL) < 0) { if (virRun(cmd, NULL) < 0)
return -1; return -1;
}
vm->def->id = -1; vm->def->id = -1;
virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason); virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, reason);
...@@ -345,9 +344,8 @@ vmwareStartVM(struct vmware_driver *driver, virDomainObjPtr vm) ...@@ -345,9 +344,8 @@ vmwareStartVM(struct vmware_driver *driver, virDomainObjPtr vm)
else else
vmwareSetSentinal(cmd, NULL); vmwareSetSentinal(cmd, NULL);
if (virRun(cmd, NULL) < 0) { if (virRun(cmd, NULL) < 0)
return -1; return -1;
}
if ((vm->def->id = vmwareExtractPid(vmxPath)) < 0) { if ((vm->def->id = vmwareExtractPid(vmxPath)) < 0) {
vmwareStopVM(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED); vmwareStopVM(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED);
......
...@@ -107,9 +107,8 @@ read_bd_stat(int device, int domid, const char *str) ...@@ -107,9 +107,8 @@ read_bd_stat(int device, int domid, const char *str)
VIR_FREE(path); VIR_FREE(path);
if (r >= 0) { if (r >= 0)
return r; return r;
}
} }
return -1; return -1;
......
...@@ -2550,15 +2550,13 @@ xenUnifiedNodeDeviceAssignedDomainId(virNodeDevicePtr dev) ...@@ -2550,15 +2550,13 @@ xenUnifiedNodeDeviceAssignedDomainId(virNodeDevicePtr dev)
/* Get active domains */ /* Get active domains */
numdomains = xenUnifiedConnectNumOfDomains(conn); numdomains = xenUnifiedConnectNumOfDomains(conn);
if (numdomains < 0) { if (numdomains < 0)
return ret; return ret;
}
if (numdomains > 0) { if (numdomains > 0) {
if (VIR_ALLOC_N(ids, numdomains) < 0) if (VIR_ALLOC_N(ids, numdomains) < 0)
goto out; goto out;
if ((numdomains = xenUnifiedConnectListDomains(conn, &ids[0], numdomains)) < 0) { if ((numdomains = xenUnifiedConnectListDomains(conn, &ids[0], numdomains)) < 0)
goto out; goto out;
}
} }
/* Get pci bdf */ /* Get pci bdf */
......
...@@ -2258,9 +2258,8 @@ get_cpu_flags(virConnectPtr conn, const char **hvm, int *pae, int *longmode) ...@@ -2258,9 +2258,8 @@ get_cpu_flags(virConnectPtr conn, const char **hvm, int *pae, int *longmode)
if (STREQLEN((const char *)&regs.r_ebx, "AuthcAMDenti", 12)) { if (STREQLEN((const char *)&regs.r_ebx, "AuthcAMDenti", 12)) {
if (pread(fd, &regs, sizeof(regs), 0x80000001) == sizeof(regs)) { if (pread(fd, &regs, sizeof(regs), 0x80000001) == sizeof(regs)) {
/* Read secure virtual machine bit (bit 2 of ECX feature ID) */ /* Read secure virtual machine bit (bit 2 of ECX feature ID) */
if ((regs.r_ecx >> 2) & 1) { if ((regs.r_ecx >> 2) & 1)
*hvm = "svm"; *hvm = "svm";
}
if ((regs.r_edx >> 6) & 1) if ((regs.r_edx >> 6) & 1)
*pae = 1; *pae = 1;
} }
...@@ -2935,9 +2934,8 @@ xenHypervisorNodeGetCellsFreeMemory(virConnectPtr conn, ...@@ -2935,9 +2934,8 @@ xenHypervisorNodeGetCellsFreeMemory(virConnectPtr conn,
else else
op_sys.u.availheap.node = cell; op_sys.u.availheap.node = cell;
ret = xenHypervisorDoV2Sys(priv->handle, &op_sys); ret = xenHypervisorDoV2Sys(priv->handle, &op_sys);
if (ret < 0) { if (ret < 0)
return -1; return -1;
}
if (hv_versions.sys_interface >= 5) if (hv_versions.sys_interface >= 5)
freeMems[i] = op_sys.u.availheap5.avail_bytes; freeMems[i] = op_sys.u.availheap5.avail_bytes;
else else
......
...@@ -147,14 +147,12 @@ wr_sync(int fd, void *buffer, size_t size, int do_read) ...@@ -147,14 +147,12 @@ wr_sync(int fd, void *buffer, size_t size, int do_read)
} }
/* recoverable error, retry */ /* recoverable error, retry */
if ((len == -1) && ((errno == EAGAIN) || (errno == EINTR))) { if ((len == -1) && ((errno == EAGAIN) || (errno == EINTR)))
continue; continue;
}
/* eof */ /* eof */
if (len == 0) { if (len == 0)
break; break;
}
/* unrecoverable error */ /* unrecoverable error */
if (len == -1) { if (len == -1) {
...@@ -1759,9 +1757,8 @@ xenDaemonNodeGetTopology(virConnectPtr conn, virCapsPtr caps) ...@@ -1759,9 +1757,8 @@ xenDaemonNodeGetTopology(virConnectPtr conn, virCapsPtr caps)
struct sexpr *root; struct sexpr *root;
root = sexpr_get(conn, "/xend/node/"); root = sexpr_get(conn, "/xend/node/");
if (root == NULL) { if (root == NULL)
return -1; return -1;
}
ret = sexpr_to_xend_topology(root, caps); ret = sexpr_to_xend_topology(root, caps);
sexpr_free(root); sexpr_free(root);
...@@ -2078,9 +2075,8 @@ xenDaemonLookupByUUID(virConnectPtr conn, const unsigned char *uuid) ...@@ -2078,9 +2075,8 @@ xenDaemonLookupByUUID(virConnectPtr conn, const unsigned char *uuid)
names = xenDaemonListDomainsOld(conn); names = xenDaemonListDomainsOld(conn);
tmp = names; tmp = names;
if (names == NULL) { if (names == NULL)
return NULL; return NULL;
}
while (*tmp != NULL) { while (*tmp != NULL) {
id = xenDaemonDomainLookupByName_ids(conn, *tmp, &ident[0]); id = xenDaemonDomainLookupByName_ids(conn, *tmp, &ident[0]);
if (id >= 0) { if (id >= 0) {
...@@ -2160,9 +2156,8 @@ xenDaemonCreateXML(virConnectPtr conn, virDomainDefPtr def) ...@@ -2160,9 +2156,8 @@ xenDaemonCreateXML(virConnectPtr conn, virDomainDefPtr def)
ret = xenDaemonDomainCreateXML(conn, sexpr); ret = xenDaemonDomainCreateXML(conn, sexpr);
VIR_FREE(sexpr); VIR_FREE(sexpr);
if (ret != 0) { if (ret != 0)
goto error; goto error;
}
/* This comes before wait_for_devices, to ensure that latter /* This comes before wait_for_devices, to ensure that latter
cleanup will destroy the domain upon failure */ cleanup will destroy the domain upon failure */
...@@ -2562,9 +2557,8 @@ xenDaemonDomainGetAutostart(virConnectPtr conn, ...@@ -2562,9 +2557,8 @@ xenDaemonDomainGetAutostart(virConnectPtr conn,
*autostart = 0; *autostart = 0;
tmp = sexpr_node(root, "domain/on_xend_start"); tmp = sexpr_node(root, "domain/on_xend_start");
if (tmp && STREQ(tmp, "start")) { if (tmp && STREQ(tmp, "start"))
*autostart = 1; *autostart = 1;
}
sexpr_free(root); sexpr_free(root);
return 0; return 0;
......
...@@ -121,9 +121,8 @@ xenXMConfigReaper(const void *payload, ...@@ -121,9 +121,8 @@ xenXMConfigReaper(const void *payload,
if (entry->refreshedAt != args->now) { if (entry->refreshedAt != args->now) {
const char *olddomname = entry->def->name; const char *olddomname = entry->def->name;
char *nameowner = (char *)virHashLookup(args->priv->nameConfigMap, olddomname); char *nameowner = (char *)virHashLookup(args->priv->nameConfigMap, olddomname);
if (nameowner && STREQ(nameowner, key)) { if (nameowner && STREQ(nameowner, key))
virHashRemoveEntry(args->priv->nameConfigMap, olddomname); virHashRemoveEntry(args->priv->nameConfigMap, olddomname);
}
return 1; return 1;
} }
return 0; return 0;
...@@ -231,9 +230,8 @@ xenXMConfigCacheAddFile(virConnectPtr conn, const char *filename) ...@@ -231,9 +230,8 @@ xenXMConfigCacheAddFile(virConnectPtr conn, const char *filename)
/* If we currently own the name, then release it and /* If we currently own the name, then release it and
re-acquire it later - just in case it was renamed */ re-acquire it later - just in case it was renamed */
nameowner = (char *)virHashLookup(priv->nameConfigMap, entry->def->name); nameowner = (char *)virHashLookup(priv->nameConfigMap, entry->def->name);
if (nameowner && STREQ(nameowner, filename)) { if (nameowner && STREQ(nameowner, filename))
virHashRemoveEntry(priv->nameConfigMap, entry->def->name); virHashRemoveEntry(priv->nameConfigMap, entry->def->name);
}
/* Clear existing config entry which needs refresh */ /* Clear existing config entry which needs refresh */
virDomainDefFree(entry->def); virDomainDefFree(entry->def);
......
...@@ -1493,16 +1493,13 @@ xenapiDomainGetXMLDesc(virDomainPtr dom, unsigned int flags) ...@@ -1493,16 +1493,13 @@ xenapiDomainGetXMLDesc(virDomainPtr dom, unsigned int flags)
} }
defPtr->maxvcpus = defPtr->vcpus = xenapiDomainGetMaxVcpus(dom); defPtr->maxvcpus = defPtr->vcpus = xenapiDomainGetMaxVcpus(dom);
enum xen_on_normal_exit action; enum xen_on_normal_exit action;
if (xen_vm_get_actions_after_shutdown(session, &action, vm)) { if (xen_vm_get_actions_after_shutdown(session, &action, vm))
defPtr->onPoweroff = xenapiNormalExitEnum2virDomainLifecycle(action); defPtr->onPoweroff = xenapiNormalExitEnum2virDomainLifecycle(action);
} if (xen_vm_get_actions_after_reboot(session, &action, vm))
if (xen_vm_get_actions_after_reboot(session, &action, vm)) {
defPtr->onReboot = xenapiNormalExitEnum2virDomainLifecycle(action); defPtr->onReboot = xenapiNormalExitEnum2virDomainLifecycle(action);
}
enum xen_on_crash_behaviour crash; enum xen_on_crash_behaviour crash;
if (xen_vm_get_actions_after_crash(session, &crash, vm)) { if (xen_vm_get_actions_after_crash(session, &crash, vm))
defPtr->onCrash = xenapiCrashExitEnum2virDomainLifecycle(action); defPtr->onCrash = xenapiCrashExitEnum2virDomainLifecycle(action);
}
xen_vm_get_platform(session, &result, vm); xen_vm_get_platform(session, &result, vm);
if (result != NULL) { if (result != NULL) {
size_t i; size_t i;
...@@ -2060,9 +2057,8 @@ call_func(const void *data, size_t len, void *user_handle, ...@@ -2060,9 +2057,8 @@ call_func(const void *data, size_t len, void *user_handle,
fflush(stdout); fflush(stdout);
#endif #endif
CURL *curl = curl_easy_init(); CURL *curl = curl_easy_init();
if (!curl) { if (!curl)
return -1; return -1;
}
xen_comms comms = { xen_comms comms = {
.func = result_func, .func = result_func,
.handle = result_handle .handle = result_handle
......
...@@ -84,9 +84,8 @@ xenapiUtil_RequestPassword(virConnectAuthPtr auth, const char *username, ...@@ -84,9 +84,8 @@ xenapiUtil_RequestPassword(virConnectAuthPtr auth, const char *username,
cred.result = NULL; cred.result = NULL;
cred.resultlen = 0; cred.resultlen = 0;
if ((*(auth->cb))(&cred, 1, auth->cbdata) < 0) { if ((*(auth->cb))(&cred, 1, auth->cbdata) < 0)
VIR_FREE(cred.result); VIR_FREE(cred.result);
}
break; break;
} }
...@@ -105,9 +104,8 @@ xenapiUtil_ParseQuery(virConnectPtr conn, virURIPtr uri, int *noVerify) ...@@ -105,9 +104,8 @@ xenapiUtil_ParseQuery(virConnectPtr conn, virURIPtr uri, int *noVerify)
for (i = 0; i < uri->paramsCount; i++) { for (i = 0; i < uri->paramsCount; i++) {
virURIParamPtr queryParam = &uri->params[i]; virURIParamPtr queryParam = &uri->params[i];
if (STRCASEEQ(queryParam->name, "no_verify")) { if (STRCASEEQ(queryParam->name, "no_verify")) {
if (noVerify == NULL) { if (noVerify == NULL)
continue; continue;
}
if (virStrToLong_i(queryParam->value, NULL, 10, noVerify) < 0 || if (virStrToLong_i(queryParam->value, NULL, 10, noVerify) < 0 ||
(*noVerify != 0 && *noVerify != 1)) { (*noVerify != 0 && *noVerify != 1)) {
xenapiSessionErrorHandler(conn, VIR_ERR_INVALID_ARG, xenapiSessionErrorHandler(conn, VIR_ERR_INVALID_ARG,
...@@ -282,9 +280,8 @@ mapDomainPinVcpu(unsigned char *cpumap, int maplen) ...@@ -282,9 +280,8 @@ mapDomainPinVcpu(unsigned char *cpumap, int maplen)
size_t i, j; size_t i, j;
for (i = 0; i < maplen; i++) { for (i = 0; i < maplen; i++) {
for (j = 0; j < 8; j++) { for (j = 0; j < 8; j++) {
if (cpumap[i] & (1 << j)) { if (cpumap[i] & (1 << j))
virBufferAsprintf(&buf, "%zu,", (8*i)+j); virBufferAsprintf(&buf, "%zu,", (8*i)+j);
}
} }
} }
if (virBufferCheckError(&buf) < 0) if (virBufferCheckError(&buf) < 0)
......
...@@ -729,9 +729,8 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def) ...@@ -729,9 +729,8 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def)
!(chr = xenParseSxprChar(str, NULL))) !(chr = xenParseSxprChar(str, NULL)))
goto cleanup; goto cleanup;
if (chr) { if (chr) {
if (VIR_ALLOC_N(def->parallels, 1) < 0) { if (VIR_ALLOC_N(def->parallels, 1) < 0)
goto cleanup; goto cleanup;
}
chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL; chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL;
chr->target.port = 0; chr->target.port = 0;
...@@ -762,9 +761,8 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def) ...@@ -762,9 +761,8 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def)
goto cleanup; goto cleanup;
chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL; chr->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL;
chr->target.port = portnum; chr->target.port = portnum;
if (VIR_APPEND_ELEMENT(def->serials, def->nserials, chr) < 0) { if (VIR_APPEND_ELEMENT(def->serials, def->nserials, chr) < 0)
goto cleanup; goto cleanup;
}
value = value->next; value = value->next;
} }
......
...@@ -1959,16 +1959,14 @@ xenFormatSxprNet(virConnectPtr conn, ...@@ -1959,16 +1959,14 @@ xenFormatSxprNet(virConnectPtr conn,
if (def->model != NULL && STREQ(def->model, "netfront")) { if (def->model != NULL && STREQ(def->model, "netfront")) {
virBufferAddLit(buf, "(type netfront)"); virBufferAddLit(buf, "(type netfront)");
} else { } else {
if (def->model != NULL) { if (def->model != NULL)
virBufferEscapeSexpr(buf, "(model '%s')", def->model); virBufferEscapeSexpr(buf, "(model '%s')", def->model);
}
/* /*
* apparently (type ioemu) breaks paravirt drivers on HVM so skip * apparently (type ioemu) breaks paravirt drivers on HVM so skip
* this from XEND_CONFIG_MAX_VERS_NET_TYPE_IOEMU * this from XEND_CONFIG_MAX_VERS_NET_TYPE_IOEMU
*/ */
if (xendConfigVersion <= XEND_CONFIG_MAX_VERS_NET_TYPE_IOEMU) { if (xendConfigVersion <= XEND_CONFIG_MAX_VERS_NET_TYPE_IOEMU)
virBufferAddLit(buf, "(type ioemu)"); virBufferAddLit(buf, "(type ioemu)");
}
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册