提交 4b4e8b57 编写于 作者: E Eric Blake

tests: avoid null pointer dereference

Unlikely to hit in real life, but clang noticed it.

* tests/commandtest.c (checkoutput, test4, test18): Avoid
unlink(NULL) on OOM.
上级 6e177fa1
......@@ -78,7 +78,8 @@ static int checkoutput(const char *testname)
ret = 0;
cleanup:
unlink(actualname);
if (actualname)
unlink(actualname);
VIR_FREE(actuallog);
VIR_FREE(actualname);
VIR_FREE(expectlog);
......@@ -240,7 +241,8 @@ static int test4(const void *unused ATTRIBUTE_UNUSED)
cleanup:
virCommandFree(cmd);
unlink(pidfile);
if (pidfile)
unlink(pidfile);
VIR_FREE(pidfile);
return ret;
}
......@@ -703,7 +705,8 @@ static int test18(const void *unused ATTRIBUTE_UNUSED)
cleanup:
virCommandFree(cmd);
unlink(pidfile);
if (pidfile)
unlink(pidfile);
VIR_FREE(pidfile);
return ret;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册