提交 496a44a7 编写于 作者: P Peter Krempa

qemuSecurityChownCallback: Don't initialize storage file subsystem for local file

virStorageFileSupportsSecurityDriver ends up initializing the storage
file backend which after the recent changes to the daemon architecture
may end up dlopening of the backend modules.

Since this is required only for remote storage we can optimize the call
by moving the check whether the backend is supported to the branch which
deals with remote storage.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
Reviewed-by: NPavel Mores <pmores@redhat.com>
上级 b62b176b
......@@ -249,10 +249,6 @@ qemuSecurityChownCallback(const virStorageSource *src,
int rv;
g_autoptr(virStorageSource) cpy = NULL;
rv = virStorageFileSupportsSecurityDriver(src);
if (rv <= 0)
return rv;
if (virStorageSourceIsLocalStorage(src)) {
/* use direct chown for local files so that the file doesn't
* need to be initialized */
......@@ -273,6 +269,9 @@ qemuSecurityChownCallback(const virStorageSource *src,
return 0;
}
if ((rv = virStorageFileSupportsSecurityDriver(src)) <= 0)
return rv;
if (!(cpy = virStorageSourceCopy(src, false)))
return -1;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册