提交 316ed412 编写于 作者: J John Ferlan 提交者: Michal Privoznik

nodeinfo: Add coverity[dead_error_begin] and [returned_null] tags

The use of switch statements inside a bounded for loop resulted in some
false positives regarding the "default:" label which cannot be reached
since each of the other case statements use the possible for loop values.
A [dead_error_begin] was added before the default label.

Commit id ebdbe25a adjusted the algorithm and the caller guarantees that
the 'params' will have a '_' in the name being searched. Add the [returned_null]
tag to the two instances.
上级 15666e02
...@@ -1124,6 +1124,7 @@ nodeSetMemoryParameterValue(virTypedParameterPtr param) ...@@ -1124,6 +1124,7 @@ nodeSetMemoryParameterValue(virTypedParameterPtr param)
int ret = -1; int ret = -1;
int rc = -1; int rc = -1;
/* coverity[returned_null] */
char *field = strchr(param->field, '_'); char *field = strchr(param->field, '_');
field++; field++;
if (virAsprintf(&path, "%s/%s", if (virAsprintf(&path, "%s/%s",
...@@ -1161,6 +1162,7 @@ nodeMemoryParametersIsAllSupported(virTypedParameterPtr params, ...@@ -1161,6 +1162,7 @@ nodeMemoryParametersIsAllSupported(virTypedParameterPtr params,
for (i = 0; i < nparams; i++) { for (i = 0; i < nparams; i++) {
virTypedParameterPtr param = &params[i]; virTypedParameterPtr param = &params[i];
/* coverity[returned_null] */
char *field = strchr(param->field, '_'); char *field = strchr(param->field, '_');
field++; field++;
if (virAsprintf(&path, "%s/%s", if (virAsprintf(&path, "%s/%s",
...@@ -1413,6 +1415,7 @@ nodeGetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED, ...@@ -1413,6 +1415,7 @@ nodeGetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED,
break; break;
/* coverity[dead_error_begin] */
default: default:
break; break;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册