virsh: Don't infloop on snapshot/storage_vol failure
Most of our completers used the pattern: if ((nITEM = virITEMListAll()) < 0) return NULL; but the virDomainSnapshot and virStorageVolume completers were instead using goto error. If the ListAll fails with -1, the cleanup label was running a loop of 'size_t i < int nITEM', which is an extreme waste of CPU cycles. Broken since their introduction in v4.1. Fixes: f81f8b62 Fixes: 4cb4b649Reported-by: NJán Tomko <jtomko@redhat.com> Signed-off-by: NEric Blake <eblake@redhat.com>
Showing
想要评论请 注册 或 登录