提交 121911c8 编写于 作者: P Peter Krempa

qemu: monitor: Refactor cleanup in qemuMonitorJSONGetOneBlockStatsInfo

Use VIR_AUTOFREE and get rid of the cleanup label.
Signed-off-by: NPeter Krempa <pkrempa@redhat.com>
Reviewed-by: NJán Tomko <jtomko@redhat.com>
上级 280e70ca
...@@ -2601,17 +2601,16 @@ qemuMonitorJSONGetOneBlockStatsInfo(virJSONValuePtr dev, ...@@ -2601,17 +2601,16 @@ qemuMonitorJSONGetOneBlockStatsInfo(virJSONValuePtr dev,
virHashTablePtr hash, virHashTablePtr hash,
bool backingChain) bool backingChain)
{ {
qemuBlockStatsPtr bstats = NULL; VIR_AUTOFREE(qemuBlockStatsPtr) bstats = NULL;
int ret = -1;
int nstats = 0; int nstats = 0;
const char *qdevname = NULL; const char *qdevname = NULL;
const char *nodename = NULL; const char *nodename = NULL;
char *devicename = NULL; VIR_AUTOFREE(char *) devicename = NULL;
virJSONValuePtr backing; virJSONValuePtr backing;
if (dev_name && if (dev_name &&
!(devicename = qemuDomainStorageAlias(dev_name, depth))) !(devicename = qemuDomainStorageAlias(dev_name, depth)))
goto cleanup; return -1;
qdevname = virJSONValueObjectGetString(dev, "qdev"); qdevname = virJSONValueObjectGetString(dev, "qdev");
nodename = virJSONValueObjectGetString(dev, "node-name"); nodename = virJSONValueObjectGetString(dev, "node-name");
...@@ -2619,35 +2618,31 @@ qemuMonitorJSONGetOneBlockStatsInfo(virJSONValuePtr dev, ...@@ -2619,35 +2618,31 @@ qemuMonitorJSONGetOneBlockStatsInfo(virJSONValuePtr dev,
if (!devicename && !qdevname && !nodename) { if (!devicename && !qdevname && !nodename) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("blockstats device entry was not in expected format")); _("blockstats device entry was not in expected format"));
goto cleanup; return -1;
} }
if (!(bstats = qemuMonitorJSONBlockStatsCollectData(dev, &nstats))) if (!(bstats = qemuMonitorJSONBlockStatsCollectData(dev, &nstats)))
goto cleanup; return -1;
if (devicename && if (devicename &&
qemuMonitorJSONAddOneBlockStatsInfo(bstats, devicename, hash) < 0) qemuMonitorJSONAddOneBlockStatsInfo(bstats, devicename, hash) < 0)
goto cleanup; return -1;
if (qdevname && STRNEQ_NULLABLE(qdevname, devicename) && if (qdevname && STRNEQ_NULLABLE(qdevname, devicename) &&
qemuMonitorJSONAddOneBlockStatsInfo(bstats, qdevname, hash) < 0) qemuMonitorJSONAddOneBlockStatsInfo(bstats, qdevname, hash) < 0)
goto cleanup; return -1;
if (nodename && if (nodename &&
qemuMonitorJSONAddOneBlockStatsInfo(bstats, nodename, hash) < 0) qemuMonitorJSONAddOneBlockStatsInfo(bstats, nodename, hash) < 0)
goto cleanup; return -1;
if (backingChain && if (backingChain &&
(backing = virJSONValueObjectGetObject(dev, "backing")) && (backing = virJSONValueObjectGetObject(dev, "backing")) &&
qemuMonitorJSONGetOneBlockStatsInfo(backing, dev_name, depth + 1, qemuMonitorJSONGetOneBlockStatsInfo(backing, dev_name, depth + 1,
hash, true) < 0) hash, true) < 0)
goto cleanup; return -1;
ret = nstats; return nstats;
cleanup:
VIR_FREE(bstats);
VIR_FREE(devicename);
return ret;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册