提交 119a6b30 编写于 作者: J John Ferlan

nwfilter: Replace virNWFilterSaveDef with virNWFilterSaveConfig

Essentially virNWFilterSaveDef executed in a different order the same
sequence of calls, so let's just make one point of reference.
Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
上级 324fd3a3
......@@ -2931,43 +2931,6 @@ virNWFilterTriggerVMFilterRebuild(void)
}
int
virNWFilterSaveDef(const char *configDir,
virNWFilterDefPtr def)
{
char uuidstr[VIR_UUID_STRING_BUFLEN];
char *xml;
int ret = -1;
char *configFile = NULL;
if (virFileMakePath(configDir) < 0) {
virReportSystemError(errno,
_("cannot create config directory %s"),
configDir);
goto error;
}
if (!(configFile = virFileBuildPath(configDir, def->name, ".xml")))
goto error;
if (!(xml = virNWFilterDefFormat(def))) {
virReportError(VIR_ERR_INTERNAL_ERROR,
"%s", _("failed to generate XML"));
goto error;
}
virUUIDFormat(def->uuid, uuidstr);
ret = virXMLSaveFile(configFile,
virXMLPickShellSafeComment(def->name, uuidstr),
"nwfilter-edit", xml);
VIR_FREE(xml);
error:
VIR_FREE(configFile);
return ret;
}
int
virNWFilterDeleteDef(const char *configDir,
virNWFilterDefPtr def)
......
......@@ -569,10 +569,6 @@ virNWFilterDefFree(virNWFilterDefPtr def);
int
virNWFilterTriggerVMFilterRebuild(void);
int
virNWFilterSaveDef(const char *configDir,
virNWFilterDefPtr def);
int
virNWFilterDeleteDef(const char *configDir,
virNWFilterDefPtr def);
......
......@@ -740,7 +740,7 @@ virNWFilterRuleIsProtocolEthernet;
virNWFilterRuleIsProtocolIPv4;
virNWFilterRuleIsProtocolIPv6;
virNWFilterRuleProtocolTypeToString;
virNWFilterSaveDef;
virNWFilterSaveConfig;
virNWFilterTriggerVMFilterRebuild;
virNWFilterUnlockFilterUpdates;
virNWFilterUnRegisterCallbackDriver;
......
......@@ -510,7 +510,7 @@ nwfilterDefineXML(virConnectPtr conn,
def = NULL;
objdef = virNWFilterObjGetDef(obj);
if (virNWFilterSaveDef(driver->configDir, objdef) < 0) {
if (virNWFilterSaveConfig(driver->configDir, objdef) < 0) {
virNWFilterObjListRemove(driver->nwfilters, obj);
goto cleanup;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册