提交 10f888e6 编写于 作者: S Sukrit Bhatnagar 提交者: Erik Skultety

util: fcp: use VIR_AUTOFREE instead of VIR_FREE for scalar types

By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.
Signed-off-by: NSukrit Bhatnagar <skrtbhtngr@gmail.com>
Reviewed-by: NErik Skultety <eskultet@redhat.com>
上级 b204fbc4
......@@ -40,16 +40,12 @@
bool
virFCIsCapableRport(const char *rport)
{
bool ret = false;
char *path = NULL;
VIR_AUTOFREE(char *) path = NULL;
if (virBuildPath(&path, SYSFS_FC_RPORT_PATH, rport) < 0)
return false;
ret = virFileExists(path);
VIR_FREE(path);
return ret;
return virFileExists(path);
}
int
......@@ -57,8 +53,8 @@ virFCReadRportValue(const char *rport,
const char *entry,
char **result)
{
int ret = -1;
char *buf = NULL, *p = NULL;
VIR_AUTOFREE(char *) buf = NULL;
char *p = NULL;
if (virFileReadValueString(&buf, "%s/%s/%s",
SYSFS_FC_RPORT_PATH, rport, entry) < 0) {
......@@ -69,13 +65,9 @@ virFCReadRportValue(const char *rport,
*p = '\0';
if (VIR_STRDUP(*result, buf) < 0)
goto cleanup;
ret = 0;
return -1;
cleanup:
VIR_FREE(buf);
return ret;
return 0;
}
#else
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册