提交 0e9823de 编写于 作者: M Michal Privoznik

remote_daemon_dispatch: Don't open code xdr_free()

At two places we are open coding xdr_free():
remoteRelayDomainEventTunable() and
remoteRelayDomainEventJobCompleted().
Bot of these functions use make_nonnull_domain() to put domain
IDs tuple into return structure and then continue encoding the
rest of structure. If that fails, they call VIR_FREE() directly.
While this okay, we should use xdr_free() which frees the whole
return structure for us.
Signed-off-by: NMichal Privoznik <mprivozn@redhat.com>
Reviewed-by: NErik Skultety <eskultet@redhat.com>
上级 29db4004
...@@ -1156,8 +1156,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn, ...@@ -1156,8 +1156,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn,
(virTypedParameterRemotePtr *) &data.params.params_val, (virTypedParameterRemotePtr *) &data.params.params_val,
&data.params.params_len, &data.params.params_len,
VIR_TYPED_PARAM_STRING_OKAY) < 0) { VIR_TYPED_PARAM_STRING_OKAY) < 0) {
VIR_FREE(data.dom.name); goto error;
return -1;
} }
remoteDispatchObjectEventSend(callback->client, remoteProgram, remoteDispatchObjectEventSend(callback->client, remoteProgram,
...@@ -1323,8 +1322,7 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, ...@@ -1323,8 +1322,7 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn,
(virTypedParameterRemotePtr *) &data.params.params_val, (virTypedParameterRemotePtr *) &data.params.params_val,
&data.params.params_len, &data.params.params_len,
VIR_TYPED_PARAM_STRING_OKAY) < 0) { VIR_TYPED_PARAM_STRING_OKAY) < 0) {
VIR_FREE(data.dom.name); goto error;
return -1;
} }
remoteDispatchObjectEventSend(callback->client, remoteProgram, remoteDispatchObjectEventSend(callback->client, remoteProgram,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册