提交 0c5ca985 编写于 作者: J John Ferlan

domain_conf: Resolve Coverity REVERSE_INULL

Coverity complains that checking for domain->def being non NULL in the
if (live) path of virDomainObjAssignDef() would be unnecessary or a
NULL deref since the call to virDomainObjIsActive() would already
dereference domain->def when checking if the def->id field was != -1.

Checked all callers to virDomainObjAssignDef() and each at some point
dereferences (vm)->def->{field} prior to calling when live is true.
上级 39b9c121
...@@ -2247,13 +2247,11 @@ void virDomainObjAssignDef(virDomainObjPtr domain, ...@@ -2247,13 +2247,11 @@ void virDomainObjAssignDef(virDomainObjPtr domain,
domain->newDef = def; domain->newDef = def;
} else { } else {
if (live) { if (live) {
if (domain->def) { /* save current configuration to be restored on domain shutdown */
/* save current configuration to be restored on domain shutdown */ if (!domain->newDef)
if (!domain->newDef) domain->newDef = domain->def;
domain->newDef = domain->def; else
else virDomainDefFree(domain->def);
virDomainDefFree(domain->def);
}
domain->def = def; domain->def = def;
} else { } else {
if (oldDef) if (oldDef)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册