提交 07943d35 编写于 作者: D Daniel P. Berrangé

build: comment on why we're not adopting certain flake8 rules

Simplify the list of ignored warnings now that we only have two left,
and document why we're not honouring them.
Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
上级 3df69e62
...@@ -882,13 +882,17 @@ sc_require_enum_last_marker: ...@@ -882,13 +882,17 @@ sc_require_enum_last_marker:
{ echo '$(ME): enum impl needs _LAST marker on second line' 1>&2; \ { echo '$(ME): enum impl needs _LAST marker on second line' 1>&2; \
exit 1; } || : exit 1; } || :
# Validate many python style rules # We're intentionally ignoring a few warnings
FLAKE8_LINE_LENGTH = E501 #
FLAKE8_WARNINGS = W504 # E501: Force breaking lines at < 80 characters results in
# some really unnatural code formatting which harms
FLAKE8_IGNORE = $(FLAKE8_LINE_LENGTH),$\ # readability.
$(FLAKE8_WARNINGS) \ #
$(NULL) # W504: Knuth code style requires the operators "or" and "and" etc
# to be at the start of line in a multi-line conditional.
# This the opposite to what is normal libvirt practice.
#
FLAKE8_IGNORE = E501,W504
sc_flake8: sc_flake8:
@if [ -n "$(FLAKE8)" ]; then \ @if [ -n "$(FLAKE8)" ]; then \
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册