提交 05388311 编写于 作者: C Cole Robinson

tests: qemuxml2xml: Break out testInfoSet*Paths

These will need to be separate to share testInfo with qemuxml2argv
Reviewed-by: NAndrea Bolognani <abologna@redhat.com>
Signed-off-by: NCole Robinson <crobinso@redhat.com>
上级 17f160b2
...@@ -129,16 +129,11 @@ testInfoSetCommon(struct testInfo *info, ...@@ -129,16 +129,11 @@ testInfoSetCommon(struct testInfo *info,
return -1; return -1;
} }
static int static int
testInfoSet(struct testInfo *info, testInfoSetPaths(struct testInfo *info,
const char *name, const char *name,
int when, int when)
int gic)
{ {
if (testInfoSetCommon(info, gic) < 0)
return -1;
if (virAsprintf(&info->inName, "%s/qemuxml2argvdata/%s.xml", if (virAsprintf(&info->inName, "%s/qemuxml2argvdata/%s.xml",
abs_srcdir, name) < 0) abs_srcdir, name) < 0)
goto error; goto error;
...@@ -186,13 +181,9 @@ testInfoSet(struct testInfo *info, ...@@ -186,13 +181,9 @@ testInfoSet(struct testInfo *info,
static const char *statusPath = abs_srcdir "/qemustatusxml2xmldata/"; static const char *statusPath = abs_srcdir "/qemustatusxml2xmldata/";
static int static int
testInfoSetStatus(struct testInfo *info, testInfoSetStatusPaths(struct testInfo *info,
const char *name, const char *name)
int gic)
{ {
if (testInfoSetCommon(info, gic) < 0)
return -1;
if (virAsprintf(&info->inName, "%s%s-in.xml", statusPath, name) < 0 || if (virAsprintf(&info->inName, "%s%s-in.xml", statusPath, name) < 0 ||
virAsprintf(&info->outActiveName, "%s%s-out.xml", statusPath, name) < 0) virAsprintf(&info->outActiveName, "%s%s-out.xml", statusPath, name) < 0)
goto error; goto error;
...@@ -236,7 +227,8 @@ mymain(void) ...@@ -236,7 +227,8 @@ mymain(void)
# define DO_TEST_FULL(name, when, gic, ...) \ # define DO_TEST_FULL(name, when, gic, ...) \
do { \ do { \
if (testInfoSet(&info, name, when, gic) < 0) { \ if (testInfoSetCommon(&info, gic) < 0 || \
testInfoSetPaths(&info, name, when) < 0) { \
VIR_TEST_DEBUG("Failed to generate test data for '%s'", name); \ VIR_TEST_DEBUG("Failed to generate test data for '%s'", name); \
return -1; \ return -1; \
} \ } \
...@@ -1256,7 +1248,8 @@ mymain(void) ...@@ -1256,7 +1248,8 @@ mymain(void)
# define DO_TEST_STATUS(name) \ # define DO_TEST_STATUS(name) \
do { \ do { \
if (testInfoSetStatus(&info, name, GIC_NONE) < 0) { \ if (testInfoSetCommon(&info, GIC_NONE) < 0 || \
testInfoSetStatusPaths(&info, name) < 0) { \
VIR_TEST_DEBUG("Failed to generate status test data for '%s'", name); \ VIR_TEST_DEBUG("Failed to generate status test data for '%s'", name); \
return -1; \ return -1; \
} \ } \
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册