• J
    cgroup: reuse buffer for getline · fcbeadf3
    Ján Tomko 提交于
    Reuse the buffer for getline and track buffer allocation
    separately from the string length to prevent unlikely
    out-of-bounds memory access.
    
    This fixes the following leak that happened when zero bytes were read:
    
    ==404== 120 bytes in 1 blocks are definitely lost in loss record 1,344 of 1,671
    ==404==    at 0x4C2C71B: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==404==    by 0x906F862: getdelim (iogetdelim.c:68)
    ==404==    by 0x52A48FB: virCgroupPartitionNeedsEscaping (vircgroup.c:1136)
    ==404==    by 0x52A0FB4: virCgroupPartitionEscape (vircgroup.c:1171)
    ==404==    by 0x52A0EA4: virCgroupNewDomainPartition (vircgroup.c:1450)
    (cherry picked from commit cc732931)
    fcbeadf3
vircgroup.c 73.5 KB