• D
    qemu_hotplug.c: user-friendlier setvcpus timeout error message · f46eb511
    Daniel Henrique Barboza 提交于
    The current 'setvcpus' timeout message requires a deeper
    understanding of QEMU/Libvirt internals to proper react to it.
    One who knows how setvcpus unplug work (it is an asynchronous
    operation between QEMU and guest that Libvirt can't know for
    sure if it failed, unless an explicit error happened during the
    timeout period) will read the message and not assume a failed
    operation. But the regular user, most often than not, will read
    it and believe that the unplug operation failed.
    
    This leads to situations where the user isn't exactly relieved
    when accessing the guest and seeing that the unplug operation
    worked. Instead, the user feel mislead by the timeout message
    setvcpus threw.
    
    Changing the timeout message to let the user know that the
    unplug status is not known, and manual inspection in the guest
    is required, is not a silver bullet. But it gives a more
    realistic expectation of what happened, as best as we can tell
    from Libvirt side anyways.
    Reviewed-by: NCole Robinson <crobinso@redhat.com>
    Signed-off-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
    f46eb511
qemu_hotplug.c 209.0 KB