• G
    qemu: Don't set address type too early during virtio disk hotplug · ea2e31fa
    Guido Günther 提交于
    f946462e changed behavior by settings
    VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI upfront. If we do so before invoking
    qemuDomainPCIAddressEnsureAddr we merely try to set the PCI slot via
    qemuDomainPCIAddressReserveSlot instead reserving a new address via
    qemuDomainPCIAddressSetNextAddr which fails with
    
    $ ~/run-tck-test domain/200-disk-hotplug.t
    ./scripts/domain/200-disk-hotplug.t .. # Creating a new transient domain
    ./scripts/domain/200-disk-hotplug.t .. 1/5 # Attaching the new disk /var/lib/jenkins/jobs/libvirt-tck-build/workspace/scratchdir/200-disk-hotplug/extra.img
    
     #   Failed test 'disk has been attached'
     #   at ./scripts/domain/200-disk-hotplug.t line 67.
     # died: Sys::Virt::Error (libvirt error code: 1, message: internal error unable to reserve PCI address 0:0:0.0
     # )
    ea2e31fa
qemu_hotplug.c 99.9 KB