• E
    util: improve user lookup helper · c1983ba4
    Eric Blake 提交于
    A future patch needs to look up pw_gid; but it is wasteful
    to crawl through getpwuid_r twice for two separate pieces
    of information, and annoying to copy that much boilerplate
    code for doing the crawl.  The current internal-only
    virGetUserEnt is also a rather awkward interface; it's easier
    to just design it to let callers request multiple pieces of
    data as needed from one traversal.
    
    And while at it, I noticed that virGetXDGDirectory could deref
    NULL if the getpwuid_r lookup fails.
    
    * src/util/virutil.c (virGetUserEnt): Alter signature.
    (virGetUserDirectory, virGetXDGDirectory, virGetUserName): Adjust
    callers.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    c1983ba4
virutil.c 51.3 KB