• L
    qemu: avoid duplicate security label restore on hostdev attach failure · c0f511ee
    Laine Stump 提交于
    This eliminates the misleading error message that was being logged
    when a vfio hostdev hotplug failed:
    
      error: unable to set user and group to '107:107' on '/dev/vfio/22':
             No such file or directory
    
    as documented in:
    
      https://bugzilla.redhat.com/show_bug.cgi?id=1035490
    
    Commit ee414b5d (pushed as a fix for Bug 1016511 and part of Bug
    1025108) replaced the single call to
    virSecurityManagerSetHostdevLabel() in qemuDomainAttachHostDevice()
    with individual calls to that same function in each
    device-type-specific attach function (for PCI, USB, and SCSI). It also
    added a corresponding call to virSecurityManagerRestoreHostdevLabel()
    in the error handling of the device-type-specific functions, but
    forgot to remove the common call to that from
    qemuDomainAttachHostDevice() - this resulted in a duplicate call to
    virSecurityManagerRestoreHostdevLabel(), with the second occurrence
    being after (e.g.) a PCI device has already been re-attached to the
    host driver, thus destroying some of the device nodes / links that we
    then attempted to re-label (e.f. /dev/vfio/22) and generating an error
    log that obscured the original error.
    c0f511ee
qemu_hotplug.c 125.3 KB