• A
    qemu: fix return value issue · c03f7f13
    Alex Jia 提交于
    whether or not previous return value is -1, the following codes will be
    executed for a inactive guest in src/qemu/qemu_driver.c:
    ret = virDomainSaveConfig(driver->configDir, persistentDef);
    and if everything is okay, 'ret' is assigned to 0, the previous 'ret'
    will be overwritten, this patch will fix this issue.
    
    * src/qemu/qemu_driver.c: avoid return value is overwritten when give a argument
      in out of blkio weight range for a inactive guest.
    
    * how to reproduce?
      % virsh blkiotune ${guestname} --weight 10
      % echo $?
    
      Note: guest must be inactive, argument 10 in out of blkio weight range,
      and can get a error information by checking libvirtd.log, however,
      virsh hasn't raised any error information, and return value is 0.
    
      https://bugzilla.redhat.com/show_bug.cgi?id=726304Signed-off-by: NAlex Jia <ajia@redhat.com>
    c03f7f13
qemu_driver.c 289.7 KB