• E
    virsh: fix regression in parsing optional integer · b9973f52
    Eric Blake 提交于
    Regression introduced in 0.8.5, commit c1564268.  The command
    'virsh freecell 0' quit working when it changed from an optional
    string to an optional integer.
    
    This patch introduces a slight change that specifying an option
    twice is now detected as an error.  It also changes things so
    that a command that has more than 1 required option will not
    complain about missing options if one but not all of the options
    were given in long format, as in 'virsh vol-create --pool p file',
    as well as making positional parsing work for all optional
    options (each positional argument is associated with the earliest
    option that has not yet been seen by name).
    
    Optional boolean options can appear before required argument
    options, because they don't affect positional argument parsing,
    and obviously a required boolean option makes no sense.
    
    Technically, this patch renders VSH_OT_STRING and VSH_OT_DATA
    redundant; but cleaning that up can be a separate patch.
    
    No command should ever need more than 32 options, right? :)
    
    * tools/virsh.c (vshCmddefGetData, vshCmddefGetOption)
    (vshCommandCheckOpts): Alter parameters to use bitmaps.
    (vshCmddefOptParse): New function.
    (vshCommandParse): Update for better handling of positional
    arguments.
    (vshCmddefHelp): Allow unit tests to validate options.
    b9973f52
virsh.c 361.0 KB