• V
    capabilities: defaultConsoleTargetType can depend on architecture · b1c88c14
    Viktor Mihajlovski 提交于
    For S390, the default console target type cannot be of type 'serial'.
    It is necessary to at least interpret the 'arch' attribute
    value of the os/type element to produce the correct default type.
    
    Therefore we need to extend the signature of defaultConsoleTargetType
    to account for architecture. As a consequence all the drivers
    supporting this capability function must be updated.
    
    Despite the amount of changed files, the only change in behavior is
    that for S390 the default console target type will be 'virtio'.
    
    N.B.: A more future-proof approach could be to to use hypervisor
    specific capabilities to determine the best possible console type.
    For instance one could add an opaque private data pointer to the
    virCaps structure (in case of QEMU to hold capsCache) which could
    then be passed to the defaultConsoleTargetType callback to determine
    the console target type.
    Seems to be however a bit overengineered for the use case...
    Signed-off-by: NViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
    b1c88c14
lxc_conf.c 7.4 KB