• E
    tests: Avoid writing into $HOME during virsh-snapshot · b1886608
    Eric Blake 提交于
    In a constrained CI environment, where it is intentional that attempts
    to write outside the current directory will fail, virsh-snapshot was
    failing:
    
    @@ -1,2 +1,3 @@
     error: invalid argument: parent s3 for snapshot s2 not found
     error: marker
    +error: Failed to create '/home/travis/.cache/libvirt/virsh': Permission denied
    FAIL virsh-snapshot (exit status: 1)
    
    But we've already solved the problem in virsh-uriprecedence: tell
    virsh to use XDG locations pointing to somewhere we can write rather
    than its default of falling back to $HOME with the test being at risk
    of breaking due to the user's environment and/or unacceptably altering
    the user's normal cache.  Hoist that solution into test-lib.sh, so
    that all scripts can use it as needed. While at it, fix a latent typo
    where XDG_RUNTIME_HOME was set to a literal relative directory name
    "XDG_CACHE_HOME" (the typo did not affect virsh-uriprecedence, but
    could matter to other clients).
    
    Fixes: 280a2b41
    Fixes: 398de147Reported-by: NDaniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: NEric Blake <eblake@redhat.com>
    b1886608
virsh-snapshot 5.3 KB