• D
    conf: add enum constants for default controller models · a302480d
    Daniel P. Berrangé 提交于
    The controller model is slightly unusual in that the default value is
    -1, not 0. As a result the default value is not covered by any of the
    existing enum cases. This in turn means that any switch() statements
    that think they have covered all cases, will in fact not match the
    default value at all. In the qemuDomainDeviceCalculatePCIConnectFlags()
    method this has caused a serious mistake where we fallthrough from the
    SCSI controller case, to the VirtioSerial controller case, and from
    the USB controller case to the IDE controller case.
    
    By adding explicit enum constant starting at -1, we can ensure switches
    remember to handle the default case.
    Reviewed-by: NJohn Ferlan <jferlan@redhat.com>
    Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
    a302480d
qemu_domain.c 354.3 KB