• E
    snapshot: don't pass NULL to QMP command creation · a14eda31
    Eric Blake 提交于
    Commit d42a2ffc caused a regression in creating a disk-only snapshot
    of a qcow2 disk; by passing the wrong variable to the monitor call,
    libvirt ended up creating JSON that looked like "format":null instead
    of the intended "format":"qcow2".
    
    To make it easier to diagnose this in the future, make JSON creation
    error out if "s:arg" is paired with NULL (it is still possible to
    use "n:arg" in the rare cases where qemu will accept a null).
    
    * src/qemu/qemu_driver.c
    (qemuDomainSnapshotCreateSingleDiskActive): Pass correct value.
    * src/qemu/qemu_monitor_json.c (qemuMonitorJSONMakeCommandRaw):
    Improve error message.
    a14eda31
qemu_driver.c 406.5 KB