• E
    snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag · 95f8e323
    Eric Blake 提交于
    We've been doing a terrible job of performing XML validation in our
    various API that parse XML with a corresponding schema (we started
    with domains back in commit dd69a14f, v1.2.12, but didn't catch all
    domain-related APIs, didn't document the use of the flag, and didn't
    cover other XML). New APIs (like checkpoints) should do the validation
    unconditionally, but it doesn't hurt to continue retrofitting existing
    APIs to at least allow the option.
    
    While there are many APIs that could be improved, this patch focuses
    on wiring up a new snapshot XML creation flag through all the
    hypervisors that support snapshots, as well as exposing it in 'virsh
    snapshot-create'.  For 'virsh snapshot-create-as', we blindly set the
    flag without a command-line option, since the XML we create from the
    command line should generally always comply (note that validation
    might cause failures where it used to succeed, such as if we tighten
    the RNG to reject a name of '../\n'); but blindly passing the flag
    means we also have to add in fallback code to disable validation if
    the server is too old to understand the flag.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Acked-by: NPeter Krempa <pkrempa@redhat.com>
    95f8e323
virsh-snapshot.c 61.3 KB